2021-11-16 01:43:25

by Xu Wang

Subject: [PATCH] dmaengine: qcom: gpi: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because
platform_get_irq() already prints an error.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/dma/qcom/gpi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 1a1b7d8458c9..94f3648f7483 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2206,10 +2206,8 @@ static int gpi_probe(struct platform_device *pdev)

/* set up irq */
ret = platform_get_irq(pdev, i);
- if (ret < 0) {
- dev_err(gpi_dev->dev, "platform_get_irq failed for %d:%d\n", i, ret);
+ if (ret < 0)
return ret;
- }
gpii->irq = ret;

/* set up channel specific register info */
--
2.25.1

2021-11-22 06:59:29

by Vinod Koul

Subject: Re: [PATCH] dmaengine: qcom: gpi: Remove unnecessary print function dev_err()

On 16-11-21, 01:33, Xu Wang wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.

Applied, thanks

--
~Vinod