2021-11-08 19:26:18

by Arnaud Pouliquen

Subject: [PATCH] rpmsg: char: Add pr_fmt() to prefix messages

Make all messages to be prefixed in a unified way.
Add pr_fmt() to achieve this.

Signed-off-by: Arnaud Pouliquen <[email protected]>
---
drivers/rpmsg/rpmsg_char.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
index b5907b80727c..d6214cb66026 100644
--- a/drivers/rpmsg/rpmsg_char.c
+++ b/drivers/rpmsg/rpmsg_char.c
@@ -9,6 +9,9 @@
* Based on rpmsg performance statistics driver by Michal Simek, which in turn
* was based on TI & Google OMX rpmsg driver.
*/
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/cdev.h>
#include <linux/device.h>
#include <linux/fs.h>
@@ -550,7 +553,7 @@ static int rpmsg_chrdev_init(void)

ret = alloc_chrdev_region(&rpmsg_major, 0, RPMSG_DEV_MAX, "rpmsg");
if (ret < 0) {
- pr_err("rpmsg: failed to allocate char dev region\n");
+ pr_err("failed to allocate char dev region\n");
return ret;
}

@@ -563,7 +566,7 @@ static int rpmsg_chrdev_init(void)

ret = register_rpmsg_driver(&rpmsg_chrdev_driver);
if (ret < 0) {
- pr_err("rpmsgchr: failed to register rpmsg driver\n");
+ pr_err("failed to register rpmsg driver\n");
class_destroy(rpmsg_class);
unregister_chrdev_region(rpmsg_major, RPMSG_DEV_MAX);
}
--
2.17.1

2021-11-18 17:27:02

by Mathieu Poirier

Subject: Re: [PATCH] rpmsg: char: Add pr_fmt() to prefix messages

On Mon, Nov 08, 2021 at 02:59:45PM +0100, Arnaud Pouliquen wrote:
> Make all messages to be prefixed in a unified way.
> Add pr_fmt() to achieve this.
>
> Signed-off-by: Arnaud Pouliquen <[email protected]>
> ---
> drivers/rpmsg/rpmsg_char.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
> index b5907b80727c..d6214cb66026 100644
> --- a/drivers/rpmsg/rpmsg_char.c
> +++ b/drivers/rpmsg/rpmsg_char.c
> @@ -9,6 +9,9 @@
> * Based on rpmsg performance statistics driver by Michal Simek, which in turn
> * was based on TI & Google OMX rpmsg driver.
> */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> #include <linux/cdev.h>
> #include <linux/device.h>
> #include <linux/fs.h>
> @@ -550,7 +553,7 @@ static int rpmsg_chrdev_init(void)
>
> ret = alloc_chrdev_region(&rpmsg_major, 0, RPMSG_DEV_MAX, "rpmsg");
> if (ret < 0) {
> - pr_err("rpmsg: failed to allocate char dev region\n");
> + pr_err("failed to allocate char dev region\n");
> return ret;
> }
>
> @@ -563,7 +566,7 @@ static int rpmsg_chrdev_init(void)
>
> ret = register_rpmsg_driver(&rpmsg_chrdev_driver);
> if (ret < 0) {
> - pr_err("rpmsgchr: failed to register rpmsg driver\n");
> + pr_err("failed to register rpmsg driver\n");

This probably the right thing to do - I will pick up this patch.

Thanks,
Mathieu

> class_destroy(rpmsg_class);
> unregister_chrdev_region(rpmsg_major, RPMSG_DEV_MAX);
> }
> --
> 2.17.1
>