2021-11-04 06:28:14

by CGEL

Subject: [PATCH linux-next] xfrm: Remove duplicate assignment

From: luo penghao <[email protected]>

The statement in the switch is repeated with the statement at the
beginning of the while loop, so this statement is meaningless.

The clang_analyzer complains as follows:

net/xfrm/xfrm_policy.c:3392:2 warning:

Value stored to 'exthdr' is never read

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: luo penghao <[email protected]>
---
net/xfrm/xfrm_policy.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 7f881f5..e8a31b9 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -3389,7 +3389,6 @@ decode_session6(struct sk_buff *skb, struct flowi *fl, bool reverse)
case NEXTHDR_DEST:
offset += ipv6_optlen(exthdr);
nexthdr = exthdr->nexthdr;
- exthdr = (struct ipv6_opt_hdr *)(nh + offset);
break;
case IPPROTO_UDP:
case IPPROTO_UDPLITE:
--
2.15.2

2021-11-19 08:38:11

by Steffen Klassert

Subject: Re: [PATCH linux-next] xfrm: Remove duplicate assignment

On Thu, Nov 04, 2021 at 06:26:21AM +0000, [email protected] wrote:
> From: luo penghao <[email protected]>
>
> The statement in the switch is repeated with the statement at the
> beginning of the while loop, so this statement is meaningless.
>
> The clang_analyzer complains as follows:
>
> net/xfrm/xfrm_policy.c:3392:2 warning:
>
> Value stored to 'exthdr' is never read
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: luo penghao <[email protected]>

Applied to ipsec-next, thanks luo!