2021-11-15 10:24:41

by Antoniu Miclaus

Subject: [PATCH v3 2/2] dt-bindings:iio:amplifiers: add ad7293 doc

Add device tree bindings for the AD7293 Power Amplifier.

Signed-off-by: Antoniu Miclaus <[email protected]>
---
no changes in v3
.../bindings/iio/amplifiers/adi,ad7293.yaml | 64 +++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml

diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
new file mode 100644
index 000000000000..9f1b2eb78af3
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/amplifiers/adi,ad7293.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AD7293 12-Bit Power Amplifier Current Controller with ADC,
+ DACs, Temperature and Current Sensors
+
+maintainers:
+ - Antoniu Miclaus <[email protected]>
+
+description: |
+ Power Amplifier drain current controller containing functionality
+ for general-purpose monitoring and control of current, voltage,
+ and temperature, integrated into a single chip solution with an
+ SPI-compatible interface.
+
+ https://www.analog.com/en/products/ad7293.html
+
+properties:
+ compatible:
+ enum:
+ - adi,ad7293
+
+ avdd-supply:
+ description:
+ AVDD voltage regulator.
+
+ vdrive-supply:
+ description:
+ VDRIVE voltage regulator.
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 1000000
+
+ reset-gpios: true
+
+required:
+ - compatible
+ - reg
+ - avdd-supply
+ - vdrive-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ ad7293@0 {
+ compatible = "adi,ad7293";
+ reg = <0>;
+ spi-max-frequency = <1000000>;
+ avdd-supply = <&avdd>;
+ vdrive-supply = <&vdrive>;
+ reset-gpios = <&gpio 10 0>;
+ };
+ };
+...
--
2.33.1

2021-11-21 12:31:13

by Jonathan Cameron

Subject: Re: [PATCH v3 2/2] dt-bindings:iio:amplifiers: add ad7293 doc

On Mon, 15 Nov 2021 12:23:40 +0200
Antoniu Miclaus <[email protected]> wrote:

> Add device tree bindings for the AD7293 Power Amplifier.
>
> Signed-off-by: Antoniu Miclaus <[email protected]>

Hi Antoniu,

A few trivial things inline that I'd missed before.

Jonathan

> ---
> no changes in v3
> .../bindings/iio/amplifiers/adi,ad7293.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
> new file mode 100644
> index 000000000000..9f1b2eb78af3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/amplifiers/adi,ad7293.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AD7293 12-Bit Power Amplifier Current Controller with ADC,
> + DACs, Temperature and Current Sensors
> +
> +maintainers:
> + - Antoniu Miclaus <[email protected]>
> +
> +description: |
> + Power Amplifier drain current controller containing functionality
> + for general-purpose monitoring and control of current, voltage,
> + and temperature, integrated into a single chip solution with an
> + SPI-compatible interface.
> +
> + https://www.analog.com/en/products/ad7293.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad7293
> +
> + avdd-supply:
> + description:
> + AVDD voltage regulator.

Not sure these descriptions add anything.
avdd-supply: true
is fine.

> +
> + vdrive-supply:
> + description:
> + VDRIVE voltage regulator.
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + reset-gpios: true

Specify how many?
maxItems: 1

> +
> +required:
> + - compatible
> + - reg
> + - avdd-supply
> + - vdrive-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + ad7293@0 {
> + compatible = "adi,ad7293";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + avdd-supply = <&avdd>;
> + vdrive-supply = <&vdrive>;
> + reset-gpios = <&gpio 10 0>;
> + };
> + };
> +...