2021-11-21 16:07:08

by David Mosberger-Tang

Subject: [PATCH] hwmon: (sht4x) Add device tree match table

This patch enables automatic loading of the sht4x module via a device
tree table entry.

Signed-off-by: David Mosberger-Tang <[email protected]>
---
drivers/hwmon/sht4x.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/hwmon/sht4x.c b/drivers/hwmon/sht4x.c
index 3415d7a0e0fc..6e53d81e32d4 100644
--- a/drivers/hwmon/sht4x.c
+++ b/drivers/hwmon/sht4x.c
@@ -281,9 +281,16 @@ static const struct i2c_device_id sht4x_id[] = {
};
MODULE_DEVICE_TABLE(i2c, sht4x_id);

+static const struct of_device_id sht4x_of_match[] = {
+ { .compatible = "sensirion,sht4x" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, sht4x_of_match);
+
static struct i2c_driver sht4x_driver = {
.driver = {
.name = "sht4x",
+ .of_match_table = sht4x_of_match
},
.probe = sht4x_probe,
.id_table = sht4x_id,
--
2.25.1

2021-11-21 16:31:43

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (sht4x) Add device tree match table

On Sun, Nov 21, 2021 at 04:07:02PM +0000, David Mosberger-Tang wrote:
> This patch enables automatic loading of the sht4x module via a device
> tree table entry.
>
> Signed-off-by: David Mosberger-Tang <[email protected]>

I'll wait for the DT patch to be approved before applying.

Please send related patches as series in the future; this should have been
patch 2/2, with the DT patch as first patch.

Thanks,
Guenter

> ---
> drivers/hwmon/sht4x.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hwmon/sht4x.c b/drivers/hwmon/sht4x.c
> index 3415d7a0e0fc..6e53d81e32d4 100644
> --- a/drivers/hwmon/sht4x.c
> +++ b/drivers/hwmon/sht4x.c
> @@ -281,9 +281,16 @@ static const struct i2c_device_id sht4x_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, sht4x_id);
>
> +static const struct of_device_id sht4x_of_match[] = {
> + { .compatible = "sensirion,sht4x" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, sht4x_of_match);
> +
> static struct i2c_driver sht4x_driver = {
> .driver = {
> .name = "sht4x",
> + .of_match_table = sht4x_of_match
> },
> .probe = sht4x_probe,
> .id_table = sht4x_id,
> --
> 2.25.1
>

2021-11-21 16:46:39

by David Mosberger-Tang

Subject: Re: [PATCH] hwmon: (sht4x) Add device tree match table

On Sun, 2021-11-21 at 08:31 -0800, Guenter Roeck wrote:
> On Sun, Nov 21, 2021 at 04:07:02PM +0000, David Mosberger-Tang wrote:
> > This patch enables automatic loading of the sht4x module via a device
> > tree table entry.
> >
> > Signed-off-by: David Mosberger-Tang <[email protected]>
>
> I'll wait for the DT patch to be approved before applying.
>
> Please send related patches as series in the future; this should have been
> patch 2/2, with the DT patch as first patch.

Ah, I misunderstood. I thought you wanted me to send the two patches
to the relevant maintainers only. I got it now.

Thanks,

--david

2021-11-30 02:20:05

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (sht4x) Add device tree match table

On Sun, Nov 21, 2021 at 04:07:02PM +0000, David Mosberger-Tang wrote:
> This patch enables automatic loading of the sht4x module via a device
> tree table entry.
>
> Signed-off-by: David Mosberger-Tang <[email protected]>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/sht4x.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hwmon/sht4x.c b/drivers/hwmon/sht4x.c
> index 3415d7a0e0fc..6e53d81e32d4 100644
> --- a/drivers/hwmon/sht4x.c
> +++ b/drivers/hwmon/sht4x.c
> @@ -281,9 +281,16 @@ static const struct i2c_device_id sht4x_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, sht4x_id);
>
> +static const struct of_device_id sht4x_of_match[] = {
> + { .compatible = "sensirion,sht4x" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, sht4x_of_match);
> +
> static struct i2c_driver sht4x_driver = {
> .driver = {
> .name = "sht4x",
> + .of_match_table = sht4x_of_match
> },
> .probe = sht4x_probe,
> .id_table = sht4x_id,