These two board files have created a reference to the existing hdmi0_con
node to update the endpoint.
I found this extra level of indirection confusing while parsing the
file, particularly as the node is in the same file.
Remove the reference node, and update the endpoint directly.
Kieran Bingham (2):
arm64: dts: renesas: ulcb: Merge hdmi0_con
arm64: dts: renesas: salvator-common: Merge hdmi0_con
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 +----
arch/arm64/boot/dts/renesas/ulcb.dtsi | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
--
2.30.2
The remote endpoint for the hdmi connector is specfied through a
reference to the hdmi0_con endpoint, which is in the same file.
Simplify by specifying the remote-endpoint directly in the hdmi0_con
endpoint.
Signed-off-by: Kieran Bingham <[email protected]>
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index bf37777dca31..6092dc4531ad 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -97,6 +97,7 @@ hdmi0-out {
port {
hdmi0_con: endpoint {
+ remote-endpoint = <&rcar_dw_hdmi0_out>;
};
};
};
@@ -424,10 +425,6 @@ dw_hdmi0_snd_in: endpoint {
};
};
-&hdmi0_con {
- remote-endpoint = <&rcar_dw_hdmi0_out>;
-};
-
#ifdef SOC_HAS_HDMI1
&hdmi1 {
status = "okay";
--
2.30.2
Hi Kieran,
On Wed, Nov 24, 2021 at 4:28 PM Kieran Bingham
<[email protected]> wrote:
> The remote endpoint for the hdmi connector is specfied through a
> reference to the hdmi0_con endpoint, which is in the same file.
>
> Simplify by specifying the remote-endpoint directly in the hdmi0_con
> endpoint.
Thanks for your patch!
I missed that when working on commit b1158c5e14b30396 ("arm64: dts:
renesas: Consolidate Salvator-X(S) HDMI0 handling")...
> Signed-off-by: Kieran Bingham <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.17.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Kieran,
Thank you for the patch.
On Wed, Nov 24, 2021 at 03:28:15PM +0000, Kieran Bingham wrote:
> The remote endpoint for the hdmi connector is specfied through a
> reference to the hdmi0_con endpoint, which is in the same file.
>
> Simplify by specifying the remote-endpoint directly in the hdmi0_con
> endpoint.
>
> Signed-off-by: Kieran Bingham <[email protected]>
This one I hadn't found earlier today, but it's equally valid.
Reviewed-by: Laurent Pinchart <[email protected]>
> ---
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index bf37777dca31..6092dc4531ad 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -97,6 +97,7 @@ hdmi0-out {
>
> port {
> hdmi0_con: endpoint {
> + remote-endpoint = <&rcar_dw_hdmi0_out>;
> };
> };
> };
> @@ -424,10 +425,6 @@ dw_hdmi0_snd_in: endpoint {
> };
> };
>
> -&hdmi0_con {
> - remote-endpoint = <&rcar_dw_hdmi0_out>;
> -};
> -
> #ifdef SOC_HAS_HDMI1
> &hdmi1 {
> status = "okay";
--
Regards,
Laurent Pinchart