2021-11-24 15:28:26

by Kieran Bingham

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: renesas: ulcb: Merge hdmi0_con

The remote endpoint for the hdmi connector is specfied through a
reference to the hdmi0_con endpoint, which is in the same file.

Simplify by specifying the remote-endpoint directly in the hdmi0_con
endpoint.

Signed-off-by: Kieran Bingham <[email protected]>
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 7edffe7f8cfa..a7e93df4ced8 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -48,6 +48,7 @@ hdmi0-out {

port {
hdmi0_con: endpoint {
+ remote-endpoint = <&rcar_dw_hdmi0_out>;
};
};
};
@@ -199,10 +200,6 @@ dw_hdmi0_snd_in: endpoint {
};
};

-&hdmi0_con {
- remote-endpoint = <&rcar_dw_hdmi0_out>;
-};
-
&i2c2 {
pinctrl-0 = <&i2c2_pins>;
pinctrl-names = "default";
--
2.30.2



2021-11-24 16:14:26

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: renesas: ulcb: Merge hdmi0_con

On Wed, Nov 24, 2021 at 4:28 PM Kieran Bingham
<[email protected]> wrote:
> The remote endpoint for the hdmi connector is specfied through a
> reference to the hdmi0_con endpoint, which is in the same file.
>
> Simplify by specifying the remote-endpoint directly in the hdmi0_con
> endpoint.
>
> Signed-off-by: Kieran Bingham <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.17.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-11-24 22:24:10

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: renesas: ulcb: Merge hdmi0_con

Hi Kieran,

Thank you for the patch.

On Wed, Nov 24, 2021 at 03:28:14PM +0000, Kieran Bingham wrote:
> The remote endpoint for the hdmi connector is specfied through a
> reference to the hdmi0_con endpoint, which is in the same file.
>
> Simplify by specifying the remote-endpoint directly in the hdmi0_con
> endpoint.
>
> Signed-off-by: Kieran Bingham <[email protected]>

I saw this earlier today and made a note to fix it. You were faster :-)

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> arch/arm64/boot/dts/renesas/ulcb.dtsi | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> index 7edffe7f8cfa..a7e93df4ced8 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -48,6 +48,7 @@ hdmi0-out {
>
> port {
> hdmi0_con: endpoint {
> + remote-endpoint = <&rcar_dw_hdmi0_out>;
> };
> };
> };
> @@ -199,10 +200,6 @@ dw_hdmi0_snd_in: endpoint {
> };
> };
>
> -&hdmi0_con {
> - remote-endpoint = <&rcar_dw_hdmi0_out>;
> -};
> -
> &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> pinctrl-names = "default";

--
Regards,

Laurent Pinchart