Subject: [PATCH] nfc: virtual_ncidev: change default device permissions

Device permissions is S_IALLUGO, with many unnecessary bits. Remove them
and also remove read and write permissions from group and others.

Before the change:
crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci

After the change:
crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci

Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
---
drivers/nfc/virtual_ncidev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nfc/virtual_ncidev.c b/drivers/nfc/virtual_ncidev.c
index 221fa3bb8705..f577449e4935 100644
--- a/drivers/nfc/virtual_ncidev.c
+++ b/drivers/nfc/virtual_ncidev.c
@@ -202,7 +202,7 @@ static int __init virtual_ncidev_init(void)
miscdev.minor = MISC_DYNAMIC_MINOR;
miscdev.name = "virtual_nci";
miscdev.fops = &virtual_ncidev_fops;
- miscdev.mode = S_IALLUGO;
+ miscdev.mode = 0600;

return misc_register(&miscdev);
}
--
2.32.0



2021-11-25 14:26:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] nfc: virtual_ncidev: change default device permissions

On 25/11/2021 15:14, Thadeu Lima de Souza Cascardo wrote:
> Device permissions is S_IALLUGO, with many unnecessary bits. Remove them
> and also remove read and write permissions from group and others.
>
> Before the change:
> crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci
>
> After the change:
> crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
> ---
> drivers/nfc/virtual_ncidev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2021-11-26 06:13:59

by Bongsu Jeon

[permalink] [raw]
Subject: Re: [PATCH] nfc: virtual_ncidev: change default device permissions

On 25/11/2021 15:14, Thadeu Lima de Souza Cascardo wrote:
> Device permissions is S_IALLUGO, with many unnecessary bits. Remove them
> and also remove read and write permissions from group and others.
>
> Before the change:
> crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci
>
> After the change:
> crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
> ---
> drivers/nfc/virtual_ncidev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/virtual_ncidev.c b/drivers/nfc/virtual_ncidev.c
> index 221fa3bb8705..f577449e4935 100644
--- a/drivers/nfc/virtual_ncidev.c
> +++ b/drivers/nfc/virtual_ncidev.c
> @@ -202,7 +202,7 @@ static int __init virtual_ncidev_init(void)
> miscdev.minor = MISC_DYNAMIC_MINOR;
> miscdev.name = "virtual_nci";
> miscdev.fops = &virtual_ncidev_fops;
> - miscdev.mode = S_IALLUGO;
> + miscdev.mode = 0600;
>
> return misc_register(&miscdev);
> }
> --

Reviewed-by: Bongsu Jeon <[email protected]>


Thanks.

2021-11-26 19:28:43

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] nfc: virtual_ncidev: change default device permissions

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 25 Nov 2021 11:14:57 -0300 you wrote:
> Device permissions is S_IALLUGO, with many unnecessary bits. Remove them
> and also remove read and write permissions from group and others.
>
> Before the change:
> crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci
>
> After the change:
> crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci
>
> [...]

Here is the summary with links:
- nfc: virtual_ncidev: change default device permissions
https://git.kernel.org/netdev/net/c/c26381f97e2a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html