2021-11-22 03:16:52

by Chengguang Xu

Subject: [RFC PATCH V6 1/7] ovl: setup overlayfs' private bdi

From: Chengguang Xu <[email protected]>

Setup overlayfs' private bdi so that we can collect
overlayfs' own dirty inodes.

Signed-off-by: Chengguang Xu <[email protected]>
---
fs/overlayfs/super.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 265181c110ae..18a12088a37b 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1984,6 +1984,10 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
if (!ofs)
goto out;

+ err = super_setup_bdi(sb);
+ if (err)
+ goto out_err;
+
err = -ENOMEM;
ofs->creator_cred = cred = prepare_creds();
if (!cred)
--
2.27.0

2021-11-26 08:54:09

by Jan Kara

Subject: Re: [RFC PATCH V6 1/7] ovl: setup overlayfs' private bdi

On Mon 22-11-21 11:00:32, Chengguang Xu wrote:
> From: Chengguang Xu <[email protected]>
>
> Setup overlayfs' private bdi so that we can collect
> overlayfs' own dirty inodes.
>
> Signed-off-by: Chengguang Xu <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/overlayfs/super.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index 265181c110ae..18a12088a37b 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -1984,6 +1984,10 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
> if (!ofs)
> goto out;
>
> + err = super_setup_bdi(sb);
> + if (err)
> + goto out_err;
> +
> err = -ENOMEM;
> ofs->creator_cred = cred = prepare_creds();
> if (!cred)
> --
> 2.27.0
>
>
--
Jan Kara <[email protected]>
SUSE Labs, CR