2021-11-26 22:14:47

by Colin Ian King

Subject: [PATCH] clk: stm32mp1: remove redundant assignment to pointer data

The pointer data is being initialized with a value and a few lines
later on being re-assigned the same value, so this re-assignment is
redundant. Clean up the code and remove it.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/clk/clk-stm32mp1.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c
index 4bd1fe7d8af4..863274aa50e3 100644
--- a/drivers/clk/clk-stm32mp1.c
+++ b/drivers/clk/clk-stm32mp1.c
@@ -2253,8 +2253,6 @@ static int stm32_rcc_reset_init(struct device *dev, void __iomem *base,
const struct stm32_rcc_match_data *data = match->data;
struct stm32_reset_data *reset_data = NULL;

- data = match->data;
-
reset_data = kzalloc(sizeof(*reset_data), GFP_KERNEL);
if (!reset_data)
return -ENOMEM;
--
2.33.1

2021-12-16 06:48:48

by Stephen Boyd

Subject: Re: [PATCH] clk: stm32mp1: remove redundant assignment to pointer data

Quoting Colin Ian King (2021-11-26 14:12:39)
> The pointer data is being initialized with a value and a few lines
> later on being re-assigned the same value, so this re-assignment is
> redundant. Clean up the code and remove it.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Applied to clk-next