2021-11-26 22:20:53

by Colin Ian King

Subject: [PATCH] EDAC/sb_edac: Remove redundant initialization of variable rc

The variable rc is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/edac/sb_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 1522d4aa2ca6..9678ab97c7ac 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -3439,7 +3439,7 @@ MODULE_DEVICE_TABLE(x86cpu, sbridge_cpuids);

static int sbridge_probe(const struct x86_cpu_id *id)
{
- int rc = -ENODEV;
+ int rc;
u8 mc, num_mc = 0;
struct sbridge_dev *sbridge_dev;
struct pci_id_table *ptable = (struct pci_id_table *)id->driver_data;
--
2.33.1

2021-12-21 11:07:24

by Borislav Petkov

Subject: Re: [PATCH] EDAC/sb_edac: Remove redundant initialization of variable rc

On Fri, Nov 26, 2021 at 10:18:48PM +0000, Colin Ian King wrote:
> The variable rc is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/edac/sb_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 1522d4aa2ca6..9678ab97c7ac 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -3439,7 +3439,7 @@ MODULE_DEVICE_TABLE(x86cpu, sbridge_cpuids);
>
> static int sbridge_probe(const struct x86_cpu_id *id)
> {
> - int rc = -ENODEV;
> + int rc;
> u8 mc, num_mc = 0;
> struct sbridge_dev *sbridge_dev;
> struct pci_id_table *ptable = (struct pci_id_table *)id->driver_data;
> --

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette