2021-11-26 23:08:59

by Colin Ian King

Subject: [PATCH] block: Remove redundant initialization of variable ret

The variable ret is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
block/bdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bdev.c b/block/bdev.c
index 886a08a045a6..26eefa5de6ca 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -665,7 +665,7 @@ static void blkdev_flush_mapping(struct block_device *bdev)
static int blkdev_get_whole(struct block_device *bdev, fmode_t mode)
{
struct gendisk *disk = bdev->bd_disk;
- int ret = 0;
+ int ret;

if (disk->fops->open) {
ret = disk->fops->open(bdev, mode);
--
2.33.1

2021-11-27 16:10:14

by Jens Axboe

Subject: Re: [PATCH] block: Remove redundant initialization of variable ret

On Fri, 26 Nov 2021 23:06:52 +0000, Colin Ian King wrote:
> The variable ret is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
>

Applied, thanks!

[1/1] block: Remove redundant initialization of variable ret
commit: a77f46727daa3febf99663ab1a43c86cf3c2b957

Best regards,
--
Jens Axboe