2021-11-27 10:50:52

by Sven Schuchmann

[permalink] [raw]
Subject: [PATCH v2] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

On most systems request for IRQ 0 will fail, phylib will print an error message
and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
is available.

Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Sven Schuchmann <[email protected]>
---
Changes v1->v2: Added "Fixes" and "Reviewed-by"
---
drivers/net/usb/lan78xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 2bfb59ae0eaf..185e08c1af31 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2398,7 +2398,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
if (dev->domain_data.phyirq > 0)
phydev->irq = dev->domain_data.phyirq;
else
- phydev->irq = 0;
+ phydev->irq = PHY_POLL;
netdev_dbg(dev->net, "phydev->irq = %d\n", phydev->irq);

/* set to AUTOMDIX */
--
2.17.1



2021-11-29 14:12:46

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH v2] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Sat, 27 Nov 2021 11:47:07 +0100 you wrote:
> On most systems request for IRQ 0 will fail, phylib will print an error message
> and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
> is available.
>
> Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
> Reviewed-by: Andrew Lunn <[email protected]>
> Signed-off-by: Sven Schuchmann <[email protected]>
>
> [...]

Here is the summary with links:
- [v2] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available
https://git.kernel.org/netdev/net/c/817b653160db

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html