2021-11-28 20:44:09

by Rikard Falkeborn

Subject: [PATCH] memory: tegra: Constify struct thermal_cooling_device_ops

The only usage of tegra210_emc_cd_ops is to pass its address to
devm_thermal_of_cooling_device_register() which is a pointer to const
struct thermal_cooling_device_ops. Make it const to allow the compiler
to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <[email protected]>
---
drivers/memory/tegra/tegra210-emc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
index 13584f9317a4..cbe1a7723514 100644
--- a/drivers/memory/tegra/tegra210-emc-core.c
+++ b/drivers/memory/tegra/tegra210-emc-core.c
@@ -711,7 +711,7 @@ static int tegra210_emc_cd_set_state(struct thermal_cooling_device *cd,
return 0;
}

-static struct thermal_cooling_device_ops tegra210_emc_cd_ops = {
+static const struct thermal_cooling_device_ops tegra210_emc_cd_ops = {
.get_max_state = tegra210_emc_cd_max_state,
.get_cur_state = tegra210_emc_cd_get_state,
.set_cur_state = tegra210_emc_cd_set_state,
--
2.34.1

2021-11-29 09:14:27

by Krzysztof Kozlowski

Subject: Re: [PATCH] memory: tegra: Constify struct thermal_cooling_device_ops

On Sun, 28 Nov 2021 21:41:58 +0100, Rikard Falkeborn wrote:
> The only usage of tegra210_emc_cd_ops is to pass its address to
> devm_thermal_of_cooling_device_register() which is a pointer to const
> struct thermal_cooling_device_ops. Make it const to allow the compiler
> to put it in read-only memory.
>
>

Applied, thanks!

[1/1] memory: tegra: Constify struct thermal_cooling_device_ops
commit: 56985dc4f437d7a77d4abede73191da20cf11429

Best regards,
--
Krzysztof Kozlowski <[email protected]>