2021-11-29 19:15:49

by Felix Fietkau

Subject: [PATCH v5 09/13] PCI: mediatek: allow selecting controller driver for airoha arch

The EN7523 SoC uses the same controller as MT7622

Signed-off-by: Felix Fietkau <[email protected]>
---
drivers/pci/controller/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 93b141110537..f1342059c2a3 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -233,7 +233,7 @@ config PCIE_ROCKCHIP_EP

config PCIE_MEDIATEK
tristate "MediaTek PCIe controller"
- depends on ARCH_MEDIATEK || COMPILE_TEST
+ depends on ARCH_AIROHA || ARCH_MEDIATEK || COMPILE_TEST
depends on OF
depends on PCI_MSI_IRQ_DOMAIN
help
--
2.30.1

2021-11-29 23:55:58

by Bjorn Helgaas

Subject: Re: [PATCH v5 09/13] PCI: mediatek: allow selecting controller driver for airoha arch

On Mon, Nov 29, 2021 at 04:33:25PM +0100, Felix Fietkau wrote:
> The EN7523 SoC uses the same controller as MT7622

If you have occasion to post a v6, please:

- Update the subject line so it starts with a capital letter,
capitalizes "Airoha" appropriately, and includes "EN7523" as your
DT patch does, and moves those close to the beginning, e.g.,

PCI: mediatek: Allow selection for Airoha EN7532

- Update the commit log so it says what this patch does. It's OK to
repeat the subject line. Add a period at end.

I expected a patch to add "airoha,en7523-pcie" to
drivers/pci/controller/pcie-mediatek.c. Did I miss it?

Oh, I see your arch/arm/boot/dts/en7523.dtsi has:

+ pcie0: pcie@1fa91000 {
+ compatible = "airoha,en7523-pcie", "mediatek,mt7622-pcie";

so I guess you just rely on the existing "mediatek,mt7622-pcie" string
in the driver?

> Signed-off-by: Felix Fietkau <[email protected]>
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 93b141110537..f1342059c2a3 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -233,7 +233,7 @@ config PCIE_ROCKCHIP_EP
>
> config PCIE_MEDIATEK
> tristate "MediaTek PCIe controller"
> - depends on ARCH_MEDIATEK || COMPILE_TEST
> + depends on ARCH_AIROHA || ARCH_MEDIATEK || COMPILE_TEST
> depends on OF
> depends on PCI_MSI_IRQ_DOMAIN
> help
> --
> 2.30.1
>

2021-12-06 20:06:08

by Bjorn Helgaas

Subject: Re: [PATCH v5 09/13] PCI: mediatek: allow selecting controller driver for airoha arch

On Mon, Nov 29, 2021 at 05:55:50PM -0600, Bjorn Helgaas wrote:
> On Mon, Nov 29, 2021 at 04:33:25PM +0100, Felix Fietkau wrote:
> > The EN7523 SoC uses the same controller as MT7622
>
> If you have occasion to post a v6, please:
>
> - Update the subject line so it starts with a capital letter,
> capitalizes "Airoha" appropriately, and includes "EN7523" as your
> DT patch does, and moves those close to the beginning, e.g.,
>
> PCI: mediatek: Allow selection for Airoha EN7532
>
> - Update the commit log so it says what this patch does. It's OK to
> repeat the subject line. Add a period at end.

Sending again since you posted a v6 without doing any of the above.

> > Signed-off-by: Felix Fietkau <[email protected]>
> > ---
> > drivers/pci/controller/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > index 93b141110537..f1342059c2a3 100644
> > --- a/drivers/pci/controller/Kconfig
> > +++ b/drivers/pci/controller/Kconfig
> > @@ -233,7 +233,7 @@ config PCIE_ROCKCHIP_EP
> >
> > config PCIE_MEDIATEK
> > tristate "MediaTek PCIe controller"
> > - depends on ARCH_MEDIATEK || COMPILE_TEST
> > + depends on ARCH_AIROHA || ARCH_MEDIATEK || COMPILE_TEST
> > depends on OF
> > depends on PCI_MSI_IRQ_DOMAIN
> > help
> > --
> > 2.30.1
> >