2021-11-30 03:32:06

by Yang Yingliang

Subject: [PATCH -next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe()

Add the missing free_netdev() before return from ltq_etop_probe()
in the error handling case.

Fixes: 14d4e308e0aa ("net: lantiq: configure the burst length in ethernet drivers")
Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/net/ethernet/lantiq_etop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 072391c494ce..14059e11710a 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -687,13 +687,13 @@ ltq_etop_probe(struct platform_device *pdev)
err = device_property_read_u32(&pdev->dev, "lantiq,tx-burst-length", &priv->tx_burst_len);
if (err < 0) {
dev_err(&pdev->dev, "unable to read tx-burst-length property\n");
- return err;
+ goto err_free;
}

err = device_property_read_u32(&pdev->dev, "lantiq,rx-burst-length", &priv->rx_burst_len);
if (err < 0) {
dev_err(&pdev->dev, "unable to read rx-burst-length property\n");
- return err;
+ goto err_free;
}

for (i = 0; i < MAX_DMA_CHAN; i++) {
--
2.25.1

2021-11-30 12:20:19

by patchwork-bot+netdevbpf

Subject: Re: [PATCH -next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe()

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Tue, 30 Nov 2021 11:38:37 +0800 you wrote:
> Add the missing free_netdev() before return from ltq_etop_probe()
> in the error handling case.
>
> Fixes: 14d4e308e0aa ("net: lantiq: configure the burst length in ethernet drivers")
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/net/ethernet/lantiq_etop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [-next] net: lantiq: fix missing free_netdev() on error in ltq_etop_probe()
https://git.kernel.org/netdev/net-next/c/2680ce7fc993

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html