2021-11-30 04:06:10

by Dongliang Mu

Subject: [PATCH] dpaa2-eth: destroy workqueue at the end of remove function

The commit c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step
timestamping") forgets to destroy workqueue at the end of remove
function.

Fix this by adding destroy_workqueue before fsl_mc_portal_free and
free_netdev.

Fixes: c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step timestamping")
Signed-off-by: Dongliang Mu <[email protected]>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index 6451c8383639..8e643567abce 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -4550,6 +4550,8 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev)

fsl_mc_portal_free(priv->mc_io);

+ destroy_workqueue(priv->dpaa2_ptp_wq);
+
dev_dbg(net_dev->dev.parent, "Removed interface %s\n", net_dev->name);

free_netdev(net_dev);
--
2.25.1

2021-11-30 12:30:23

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] dpaa2-eth: destroy workqueue at the end of remove function

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Tue, 30 Nov 2021 12:05:54 +0800 you wrote:
> The commit c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step
> timestamping") forgets to destroy workqueue at the end of remove
> function.
>
> Fix this by adding destroy_workqueue before fsl_mc_portal_free and
> free_netdev.
>
> [...]

Here is the summary with links:
- dpaa2-eth: destroy workqueue at the end of remove function
https://git.kernel.org/netdev/net/c/f4a8adbfe484

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html