2021-11-30 11:02:27

by Tianchen Ding

[permalink] [raw]
Subject: [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

There's build error while CONFIG_REGMAP_MMIO is not set
and CONFIG_MDIO_MSCC_MIIM=m.

ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/net/mdio/mdio-mscc-miim.ko] undefined!

Add the depend of REGMAP_MMIO to fix it.

Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Tianchen Ding <[email protected]>
---
drivers/net/mdio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig
index 6da1fcb25847..bfa16826a6e1 100644
--- a/drivers/net/mdio/Kconfig
+++ b/drivers/net/mdio/Kconfig
@@ -141,7 +141,7 @@ config MDIO_MVUSB

config MDIO_MSCC_MIIM
tristate "Microsemi MIIM interface support"
- depends on HAS_IOMEM
+ depends on HAS_IOMEM && REGMAP_MMIO
select MDIO_DEVRES
help
This driver supports the MIIM (MDIO) interface found in the network
--
2.27.0



2021-11-30 18:13:31

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

On Tue, Nov 30, 2021 at 07:02:09PM +0800, Tianchen Ding wrote:
> There's build error while CONFIG_REGMAP_MMIO is not set
> and CONFIG_MDIO_MSCC_MIIM=m.
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/net/mdio/mdio-mscc-miim.ko] undefined!
>
> Add the depend of REGMAP_MMIO to fix it.
>
> Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
> Signed-off-by: Tianchen Ding <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2021-12-02 03:01:06

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 30 Nov 2021 19:02:09 +0800 you wrote:
> There's build error while CONFIG_REGMAP_MMIO is not set
> and CONFIG_MDIO_MSCC_MIIM=m.
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/net/mdio/mdio-mscc-miim.ko] undefined!
>
> Add the depend of REGMAP_MMIO to fix it.
>
> [...]

Here is the summary with links:
- net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM
https://git.kernel.org/netdev/net-next/c/8057cbb8335c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html