2021-11-30 22:14:08

by Nathan Chancellor

Subject: [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()

Clang warns:

drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
return ret;
^~~

ret is only assigned in an error path now so just return 0 directly.

Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1517
Reviewed-by: Russ Weight <[email protected]>
Reviewed-by: Tom Rix <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
---

v1 -> v2: https://lore.kernel.org/r/[email protected]/

* Drop clang's suggestion text (Tom).

* Pick up Russ and Tom's review tags.

drivers/fpga/stratix10-soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 737d14c6e0de..357cea58ec98 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
}

platform_set_drvdata(pdev, mgr);
- return ret;
+ return 0;

probe_err:
stratix10_svc_free_channel(priv->chan);

base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
--
2.34.1

2021-12-01 00:55:45

by Xu Yilun

Subject: Re: [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()

On Tue, Nov 30, 2021 at 03:11:24PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
> return ret;
> ^~~
>
> ret is only assigned in an error path now so just return 0 directly.
>
> Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1517
> Reviewed-by: Russ Weight <[email protected]>
> Reviewed-by: Tom Rix <[email protected]>
> Signed-off-by: Nathan Chancellor <[email protected]>

Acked-by: Xu Yilun <[email protected]>

Thanks,
Yilun

> ---
>
> v1 -> v2: https://lore.kernel.org/r/[email protected]/
>
> * Drop clang's suggestion text (Tom).
>
> * Pick up Russ and Tom's review tags.
>
> drivers/fpga/stratix10-soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 737d14c6e0de..357cea58ec98 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
> }
>
> platform_set_drvdata(pdev, mgr);
> - return ret;
> + return 0;
>
> probe_err:
> stratix10_svc_free_channel(priv->chan);
>
> base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
> --
> 2.34.1

2021-12-03 04:10:18

by Moritz Fischer

Subject: Re: [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()

On Tue, Nov 30, 2021 at 03:11:24PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
> return ret;
> ^~~
>
> ret is only assigned in an error path now so just return 0 directly.
>
> Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1517
> Reviewed-by: Russ Weight <[email protected]>
> Reviewed-by: Tom Rix <[email protected]>
> Signed-off-by: Nathan Chancellor <[email protected]>
> ---
>
> v1 -> v2: https://lore.kernel.org/r/[email protected]/
>
> * Drop clang's suggestion text (Tom).
>
> * Pick up Russ and Tom's review tags.
>
> drivers/fpga/stratix10-soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 737d14c6e0de..357cea58ec98 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
> }
>
> platform_set_drvdata(pdev, mgr);
> - return ret;
> + return 0;
>
> probe_err:
> stratix10_svc_free_channel(priv->chan);
>
> base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
> --
> 2.34.1
>
Applied to for-next,

Thanks