2021-12-01 11:11:09

by Li Zhijian

Subject: [PATCH 1/3] selftest: net: Correct case name

ipv6_addr_bind/ipv4_addr_bind are function name.

Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test")
Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test")
Signed-off-by: Li Zhijian <[email protected]>
---
tools/testing/selftests/net/fcnal-test.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 3313566ce906..7f5b265fcb90 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -4002,8 +4002,8 @@ EOF
################################################################################
# main

-TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_addr_bind ipv4_runtime ipv4_netfilter"
-TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_addr_bind ipv6_runtime ipv6_netfilter"
+TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
+TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
TESTS_OTHER="use_cases"

PAUSE_ON_FAIL=no
--
2.32.0

2021-12-01 11:11:53

by Li Zhijian

Subject: [PATCH 2/3] selftests: add option to list all avaliable tests

$ ./fcnal-test.sh -l
Test names: ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter
ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter
use_cases

Signed-off-by: Li Zhijian <[email protected]>
---
tools/testing/selftests/net/fcnal-test.sh | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 7f5b265fcb90..9111b8952ac8 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -3993,6 +3993,7 @@ usage: ${0##*/} OPTS
-4 IPv4 tests only
-6 IPv6 tests only
-t <test> Test name/set to run
+ -l List all avaible tests
-p Pause on fail
-P Pause after each test
-v Be verbose
@@ -4006,10 +4007,15 @@ TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
TESTS_OTHER="use_cases"

+list()
+{
+ echo "Test names: $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER"
+}
+
PAUSE_ON_FAIL=no
PAUSE=no

-while getopts :46t:pPvh o
+while getopts :46lt:pPvh o
do
case $o in
4) TESTS=ipv4;;
@@ -4018,6 +4024,7 @@ do
p) PAUSE_ON_FAIL=yes;;
P) PAUSE=yes;;
v) VERBOSE=1;;
+ l) list; exit 0;;
h) usage; exit 0;;
*) usage; exit 1;;
esac
--
2.32.0

2021-12-01 11:11:53

by Li Zhijian

Subject: [PATCH 3/3] selftest: net: remove meaningless help option

$ ./fcnal-test.sh -t help
Test names: help

Signed-off-by: Li Zhijian <[email protected]>
---
tools/testing/selftests/net/fcnal-test.sh | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 9111b8952ac8..a4d86862764d 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -4075,8 +4075,6 @@ do
# setup namespaces and config, but do not run any tests
setup) setup; exit 0;;
vrf_setup) setup "yes"; exit 0;;
-
- help) echo "Test names: $TESTS"; exit 0;;
esac
done

--
2.32.0

2021-12-01 11:19:54

by Li Zhijian

Subject: [PATCH v2 2/3] selftests: add option to list all available tests

$ ./fcnal-test.sh -l
Test names: ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter
ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter
use_cases

Signed-off-by: Li Zhijian <[email protected]>
---
tools/testing/selftests/net/fcnal-test.sh | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 7f5b265fcb90..9111b8952ac8 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -3993,6 +3993,7 @@ usage: ${0##*/} OPTS
-4 IPv4 tests only
-6 IPv6 tests only
-t <test> Test name/set to run
+ -l List all available tests
-p Pause on fail
-P Pause after each test
-v Be verbose
@@ -4006,10 +4007,15 @@ TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
TESTS_OTHER="use_cases"

+list()
+{
+ echo "Test names: $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER"
+}
+
PAUSE_ON_FAIL=no
PAUSE=no

-while getopts :46t:pPvh o
+while getopts :46lt:pPvh o
do
case $o in
4) TESTS=ipv4;;
@@ -4018,6 +4024,7 @@ do
p) PAUSE_ON_FAIL=yes;;
P) PAUSE=yes;;
v) VERBOSE=1;;
+ l) list; exit 0;;
h) usage; exit 0;;
*) usage; exit 1;;
esac
--
2.32.0

2021-12-01 11:29:41

by Zhijian Li (Fujitsu)

Subject: Re: [PATCH 2/3] selftests: add option to list all avaliable tests

sent V2 to fix a typo


On 01/12/2021 19:10, Li Zhijian wrote:
> $ ./fcnal-test.sh -l
> Test names: ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter
> ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter
> use_cases
>
> Signed-off-by: Li Zhijian <[email protected]>
> ---
> tools/testing/selftests/net/fcnal-test.sh | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
> index 7f5b265fcb90..9111b8952ac8 100755
> --- a/tools/testing/selftests/net/fcnal-test.sh
> +++ b/tools/testing/selftests/net/fcnal-test.sh
> @@ -3993,6 +3993,7 @@ usage: ${0##*/} OPTS
> -4 IPv4 tests only
> -6 IPv6 tests only
> -t <test> Test name/set to run
> + -l List all avaible tests
> -p Pause on fail
> -P Pause after each test
> -v Be verbose
> @@ -4006,10 +4007,15 @@ TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
> TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
> TESTS_OTHER="use_cases"
>
> +list()
> +{
> + echo "Test names: $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER"
> +}
> +
> PAUSE_ON_FAIL=no
> PAUSE=no
>
> -while getopts :46t:pPvh o
> +while getopts :46lt:pPvh o
> do
> case $o in
> 4) TESTS=ipv4;;
> @@ -4018,6 +4024,7 @@ do
> p) PAUSE_ON_FAIL=yes;;
> P) PAUSE=yes;;
> v) VERBOSE=1;;
> + l) list; exit 0;;
> h) usage; exit 0;;
> *) usage; exit 1;;
> esac

2021-12-02 01:48:44

by Jakub Kicinski

Subject: Re: [PATCH 2/3] selftests: add option to list all avaliable tests

On Wed, 1 Dec 2021 11:22:03 +0000 [email protected] wrote:
> sent V2 to fix a typo

You need to resend the entire series, patchwork does not understand
updating single patches:

https://patchwork.kernel.org/project/netdevbpf/list/?series=588501
https://patchwork.kernel.org/project/netdevbpf/list/?series=588507

2021-12-02 01:53:18

by Jakub Kicinski

Subject: Re: [PATCH 1/3] selftest: net: Correct case name

On Wed, 1 Dec 2021 19:10:23 +0800 Li Zhijian wrote:
> Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test")
> Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test")

Fixes tag: Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test")
Has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Fixes tag: Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test")
Has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

2021-12-02 01:54:36

by Jakub Kicinski

Subject: Re: [PATCH 3/3] selftest: net: remove meaningless help option

On Wed, 1 Dec 2021 19:10:25 +0800 Li Zhijian wrote:
> $ ./fcnal-test.sh -t help
> Test names: help
>
> Signed-off-by: Li Zhijian <[email protected]>

Not sure why the "help" test was added in the first place but could you
provide motivation for the patch in the commit message?

2021-12-02 01:54:41

by Jakub Kicinski

Subject: Re: [PATCH 1/3] selftest: net: Correct case name

On Wed, 1 Dec 2021 19:10:23 +0800 Li Zhijian wrote:
> ipv6_addr_bind/ipv4_addr_bind are function name.
>
> Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test")
> Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test")
> Signed-off-by: Li Zhijian <[email protected]>

Please send this patch separately from patches 2 and 3. This one is
a fix (AFAIU) and needs to be applied to a different tree. Patches 2
and 3 look like improvements / cleanups.

2021-12-02 02:20:00

by Li Zhijian

Subject: Re: [PATCH 1/3] selftest: net: Correct case name

on 2021/12/2 9:54, Jakub Kicinski wrote:
> On Wed, 1 Dec 2021 19:10:23 +0800 Li Zhijian wrote:
>> ipv6_addr_bind/ipv4_addr_bind are function name.
>>
>> Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test")
>> Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test")
>> Signed-off-by: Li Zhijian <[email protected]>
> Please send this patch separately from patches 2 and 3. This one is
> a fix (AFAIU) and needs to be applied to a different tree. Patches 2
> and 3 look like improvements / cleanups.
>
Got it,  I will fix it ASAP

Thanks

Zhijian