2021-12-01 17:44:42

by Lucas Tanure

[permalink] [raw]
Subject: [PATCH 1/2] ASoC: amd: Fix dependency for SPI master

Select SPI_MASTER as is using CS35L41 SPI driver

Fixes: 96792fdd77cd1 ("ASoC: amd: enable vangogh platform machine driver build")

Signed-off-by: Lucas Tanure <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 092966ff5ea7..8961b8fd23eb 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH
tristate "AMD Vangogh support for NAU8821 CS35L41"
select SND_SOC_NAU8821
select SND_SOC_CS35L41_SPI
- depends on SND_SOC_AMD_ACP5x && I2C
+ depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER
help
This option enables machine driver for Vangogh platform
using NAU8821 and CS35L41 codecs.
--
2.34.1



2021-12-01 17:49:27

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] ASoC: amd: Fix dependency for SPI master

On Wed, Dec 01, 2021 at 05:43:06PM +0000, Lucas Tanure wrote:
> Select SPI_MASTER as is using CS35L41 SPI driver

> - depends on SND_SOC_AMD_ACP5x && I2C
> + depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER

This is a depends not a select (which is good, a select wouldn't be
appropriate here).


Attachments:
(No filename) (296.00 B)
signature.asc (488.00 B)
Download all attachments

2021-12-02 13:40:49

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] ASoC: amd: Fix dependency for SPI master

On Wed, 1 Dec 2021 17:43:06 +0000, Lucas Tanure wrote:
> Select SPI_MASTER as is using CS35L41 SPI driver
>
> Fixes: 96792fdd77cd1 ("ASoC: amd: enable vangogh platform machine driver build")
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: Fix dependency for SPI master
commit: 19a628d8f1a6c16263d8037a918427207c8a95a0
[2/2] ASoC: cs35l41: Fix undefined reference to core functions
commit: 0695ad92fe1a0bb7697eb92c6a145a73c5ab0e24

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark