2021-12-02 14:48:32

by YC Hung

Subject: [PATCH v6] dt-bindings: dsp: mediatek: Add mt8195 DSP binding support

From: "yc.hung" <[email protected]>

This describes the mt8195 DSP device tree node.

Signed-off-by: yc.hung <[email protected]>
---
Changes since v5:
Remove sub node "sound" and "mediatek,platform", "mediatek,dptx-codec",
"mediatek,hdmi-codec" properties. Let dsp node as an individual node and
sound card has phandle of this dsp node per discussion in
https://github.com/thesofproject/linux/pull/3239

Changes since v4:
- remove patch 1 with clocks as it will be reviewed and merged to SOF tree.
https://github.com/thesofproject/linux/pull/3237
- refine DT file binding files with Rob's comments.
---
.../bindings/dsp/mtk,mt8195-dsp.yaml | 19 -------------------
1 file changed, 19 deletions(-)

diff --git a/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
index f8bacd50b018..33db11ee2336 100644
--- a/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
+++ b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
@@ -70,22 +70,6 @@ properties:
- description: A phandle to a reserved memory region is used for dma buffer between host and DSP.
- description: A phandle to a reserved memory region is used for DSP system memory.

- model:
- $ref: /schemas/types.yaml#/definitions/string
- description: User specified audio sound card name
-
- mediatek,platform:
- $ref: "/schemas/types.yaml#/definitions/phandle"
- description: The phandle of MT8195 ASoC platform.
-
- mediatek,dptx-codec:
- $ref: "/schemas/types.yaml#/definitions/phandle"
- description: The phandle of MT8195 Display Port Tx codec node.
-
- mediatek,hdmi-codec:
- $ref: "/schemas/types.yaml#/definitions/phandle"
- description: The phandle of MT8195 HDMI codec node.
-
required:
- compatible
- reg
@@ -98,7 +82,6 @@ required:
- power-domains
- mbox-names
- mboxes
- - mediatek,platform

additionalProperties: false

@@ -130,6 +113,4 @@ examples:
power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
mbox-names = "mbox0", "mbox1";
mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
- mediatek,dptx-codec = <&dp_tx>;
- mediatek,platform = <&afe>;
};
--
2.18.0

2021-12-10 20:10:32

by Rob Herring (Arm)

Subject: Re: [PATCH v6] dt-bindings: dsp: mediatek: Add mt8195 DSP binding support

On Thu, Dec 02, 2021 at 10:48:18PM +0800, YC Hung wrote:
> From: "yc.hung" <[email protected]>
>
> This describes the mt8195 DSP device tree node.

This doesn't match the change.

>
> Signed-off-by: yc.hung <[email protected]>
> ---
> Changes since v5:
> Remove sub node "sound" and "mediatek,platform", "mediatek,dptx-codec",
> "mediatek,hdmi-codec" properties. Let dsp node as an individual node and
> sound card has phandle of this dsp node per discussion in
> https://github.com/thesofproject/linux/pull/3239
>
> Changes since v4:
> - remove patch 1 with clocks as it will be reviewed and merged to SOF tree.
> https://github.com/thesofproject/linux/pull/3237
> - refine DT file binding files with Rob's comments.
> ---
> .../bindings/dsp/mtk,mt8195-dsp.yaml | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> index f8bacd50b018..33db11ee2336 100644
> --- a/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> @@ -70,22 +70,6 @@ properties:
> - description: A phandle to a reserved memory region is used for dma buffer between host and DSP.
> - description: A phandle to a reserved memory region is used for DSP system memory.
>
> - model:
> - $ref: /schemas/types.yaml#/definitions/string
> - description: User specified audio sound card name
> -
> - mediatek,platform:
> - $ref: "/schemas/types.yaml#/definitions/phandle"
> - description: The phandle of MT8195 ASoC platform.
> -
> - mediatek,dptx-codec:
> - $ref: "/schemas/types.yaml#/definitions/phandle"
> - description: The phandle of MT8195 Display Port Tx codec node.
> -
> - mediatek,hdmi-codec:
> - $ref: "/schemas/types.yaml#/definitions/phandle"
> - description: The phandle of MT8195 HDMI codec node.
> -
> required:
> - compatible
> - reg
> @@ -98,7 +82,6 @@ required:
> - power-domains
> - mbox-names
> - mboxes
> - - mediatek,platform
>
> additionalProperties: false
>
> @@ -130,6 +113,4 @@ examples:
> power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> mbox-names = "mbox0", "mbox1";
> mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
> - mediatek,dptx-codec = <&dp_tx>;
> - mediatek,platform = <&afe>;
> };
> --
> 2.18.0
>
>