2021-12-03 06:11:38

by Zheyu Ma

[permalink] [raw]
Subject: [PATCH] dmaengine: dw-edma: Fix error handling in dw_edma_pcied_probe()

When err is a non-zero value, it means failure.

Signed-off-by: Zheyu Ma <[email protected]>
---
drivers/dma/dw-edma/dw-edma-pcie.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
index 198f6cd8ac1b..92c4f5b7d229 100644
--- a/drivers/dma/dw-edma/dw-edma-pcie.c
+++ b/drivers/dma/dw-edma/dw-edma-pcie.c
@@ -187,12 +187,10 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,

/* DMA configuration */
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
- if (!err) {
+ if (err) {
pci_err(pdev, "DMA mask 64 set failed\n");
return err;
} else {
- pci_err(pdev, "DMA mask 64 set failed\n");
-
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (err) {
pci_err(pdev, "DMA mask 32 set failed\n");
--
2.25.1