2021-12-04 01:29:33

by Guangbin Huang

Subject: [PATCH net-next] Revert "net: hns3: add void before function which don't receive ret"

This reverts commit 5ac4f180bd07116c1e57858bc3f6741adbca3eb6.

Sorry for taking no notice that the function devlink_register() has been
already declared as void, so it is needs to revert this patch.

Signed-off-by: Guangbin Huang <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c | 2 +-
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
index 9c3199d3c8ee..4c441e6a5082 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
@@ -120,7 +120,7 @@ int hclge_devlink_init(struct hclge_dev *hdev)
hdev->devlink = devlink;

devlink_set_features(devlink, DEVLINK_F_RELOAD);
- (void)devlink_register(devlink);
+ devlink_register(devlink);
return 0;
}

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
index 75d2926729d3..fdc19868b818 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
@@ -122,7 +122,7 @@ int hclgevf_devlink_init(struct hclgevf_dev *hdev)
hdev->devlink = devlink;

devlink_set_features(devlink, DEVLINK_F_RELOAD);
- (void)devlink_register(devlink);
+ devlink_register(devlink);
return 0;
}

--
2.33.0

2021-12-07 00:40:14

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] Revert "net: hns3: add void before function which don't receive ret"

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Sat, 4 Dec 2021 09:24:48 +0800 you wrote:
> This reverts commit 5ac4f180bd07116c1e57858bc3f6741adbca3eb6.
>
> Sorry for taking no notice that the function devlink_register() has been
> already declared as void, so it is needs to revert this patch.
>
> Signed-off-by: Guangbin Huang <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] Revert "net: hns3: add void before function which don't receive ret"
https://git.kernel.org/netdev/net-next/c/364d470d5470

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html