2021-12-06 09:06:45

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the v4l-dvb-next tree

---

Hi all,

In commit

c1c95d709941 ("media: uvcvideo: Increase UVC_CTRL_CONTROL_TIMEOUT to 5 seconds.")

Fixes tag

Fixes:

has these problem(s):

- No SHA1 recognised

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (488.00 B)
OpenPGP digital signature

2021-12-06 09:27:48

by Mauro Carvalho Chehab

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the v4l-dvb-next tree

---

Em Mon, 6 Dec 2021 20:06:39 +1100
Stephen Rothwell <[email protected]> escreveu:

> Hi all,
>
> In commit
>
> c1c95d709941 ("media: uvcvideo: Increase UVC_CTRL_CONTROL_TIMEOUT to 5 seconds.")
>
> Fixes tag
>
> Fixes:
>
> has these problem(s):
>
> - No SHA1 recognised
>
Thanks! This is not actually a fixes tag, just a text to tell what
runtime errors were addressed.

So, I'm changing the description to:

media: uvcvideo: Increase UVC_CTRL_CONTROL_TIMEOUT to 5 seconds.

Some uvc devices appear to require the maximum allowed USB timeout
for GET_CUR/SET_CUR requests.

So lets just bump the UVC control timeout to 5 seconds which is the
same as the usb ctrl get/set defaults:
USB_CTRL_GET_TIMEOUT 5000
USB_CTRL_SET_TIMEOUT 5000

It fixes the following runtime warnings:
Failed to query (GET_CUR) UVC control 11 on unit 2: -110 (exp. 1).
Failed to query (SET_CUR) UVC control 3 on unit 2: -110 (exp. 2).


in order to make it clearer.

Thanks,
Mauro