I tried running the NTFS3 driver on a MIPS big endian system and
noticed various errors when it tried to access bitmaps structures
that are stored as little endian on disk.
These patches were mainly tested in a qemu mips environment.
I'm open for suggestions how to better implement the second patch
"add functions to modify LE bitmaps". It adds copies of two functions
from lib/bitmap.c but modified to work with little endian bitmaps.
Other filesystems seem to have similar functions defined locally like
le_bitmap_set in btrfs or ext4_set_bits in ext4 but no global
implementation exists.
Thomas Kühnel (3):
fs/ntfs3: fix endian conversion in ni_fname_name
fs/ntfs3: add functions to modify LE bitmaps
fs/ntfs3: use _le variants of bitops functions
fs/ntfs3/bitmap.c | 56 +++++++++++++++++++++++++++++++++++++++-------
fs/ntfs3/frecord.c | 4 +++-
fs/ntfs3/fslog.c | 4 ++--
fs/ntfs3/fsntfs.c | 8 +++----
fs/ntfs3/index.c | 14 ++++++------
fs/ntfs3/ntfs_fs.h | 3 +++
6 files changed, 67 insertions(+), 22 deletions(-)
base-commit: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
--
2.25.1
On 07.12.2021 14:24, Thomas Kühnel wrote:
> I tried running the NTFS3 driver on a MIPS big endian system and
> noticed various errors when it tried to access bitmaps structures
> that are stored as little endian on disk.
>
> These patches were mainly tested in a qemu mips environment.
>
> I'm open for suggestions how to better implement the second patch
> "add functions to modify LE bitmaps". It adds copies of two functions
> from lib/bitmap.c but modified to work with little endian bitmaps.
> Other filesystems seem to have similar functions defined locally like
> le_bitmap_set in btrfs or ext4_set_bits in ext4 but no global
> implementation exists.
>
> Thomas Kühnel (3):
> fs/ntfs3: fix endian conversion in ni_fname_name
> fs/ntfs3: add functions to modify LE bitmaps
> fs/ntfs3: use _le variants of bitops functions
>
> fs/ntfs3/bitmap.c | 56 +++++++++++++++++++++++++++++++++++++++-------
> fs/ntfs3/frecord.c | 4 +++-
> fs/ntfs3/fslog.c | 4 ++--
> fs/ntfs3/fsntfs.c | 8 +++----
> fs/ntfs3/index.c | 14 ++++++------
> fs/ntfs3/ntfs_fs.h | 3 +++
> 6 files changed, 67 insertions(+), 22 deletions(-)
>
>
> base-commit: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
Hello Thomas,
Thanks for patches, they have been applied long ago.
Sorry for not responding immediately.