2021-12-08 17:33:36

by José Expósito

Subject: [PATCH] Input: goodix - Fix memory leak in goodix_firmware_upload

Addresses-Coverity-ID: 1493934 ("Resource leak")
Signed-off-by: José Expósito <[email protected]>
---
drivers/input/touchscreen/goodix_fwupload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/goodix_fwupload.c b/drivers/input/touchscreen/goodix_fwupload.c
index c1e7a2413078..191d4f38d991 100644
--- a/drivers/input/touchscreen/goodix_fwupload.c
+++ b/drivers/input/touchscreen/goodix_fwupload.c
@@ -207,7 +207,7 @@ static int goodix_firmware_upload(struct goodix_ts_data *ts)

error = goodix_reset_no_int_sync(ts);
if (error)
- return error;
+ goto release;

error = goodix_enter_upload_mode(ts->client);
if (error)
--
2.25.1

2021-12-10 05:19:54

by Dmitry Torokhov

Subject: Re: [PATCH] Input: goodix - Fix memory leak in goodix_firmware_upload

On Wed, Dec 08, 2021 at 06:33:21PM +0100, Jos? Exp?sito wrote:
> Addresses-Coverity-ID: 1493934 ("Resource leak")
> Signed-off-by: Jos? Exp?sito <[email protected]>

Applied, thank you.

--
Dmitry