2021-12-09 13:14:21

by Xiang wangx

Subject: [PATCH] gpio: bcm-kona:add const to of_device_id

struct of_device_id should normally be const.

Signed-off-by: Xiang wangx <[email protected]>
---
drivers/gpio/gpio-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index d329a143f5ec..9cb3587d1441 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -505,7 +505,7 @@ static struct irq_chip bcm_gpio_irq_chip = {
.irq_release_resources = bcm_kona_gpio_irq_relres,
};

-static struct of_device_id const bcm_kona_gpio_of_match[] = {
+static const struct of_device_id const bcm_kona_gpio_of_match[] = {
{ .compatible = "brcm,kona-gpio" },
{}
};
--
2.20.1

2021-12-09 16:59:52

by Florian Fainelli

Subject: Re: [PATCH] gpio: bcm-kona:add const to of_device_id

On 12/9/21 5:12 AM, Xiang wangx wrote:
> struct of_device_id should normally be const.
>
> Signed-off-by: Xiang wangx <[email protected]>

Acked-by: Florian Fainelli <[email protected]>

Would be nice to add a space in the subject and do:

gpio: bcm-kona: add const to of_device_id

While applying if not asking too much from maintainers ;)
--
Florian