2021-12-09 17:15:30

by Jangwoong Kim

Subject: [PATCH v4] futex: Clarify comment at futex_wait_multiple_setup()

From: Jangwoong Kim <[email protected]>

Signed-off-by: Jangwoong Kim <[email protected]>
---
kernel/futex/waitwake.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c
index 4ce0923f1ce3..c7a14ebfe61d 100644
--- a/kernel/futex/waitwake.c
+++ b/kernel/futex/waitwake.c
@@ -454,9 +454,9 @@ static int futex_wait_multiple_setup(struct futex_vector *vs, int count, int *wo
__set_current_state(TASK_RUNNING);

/*
- * Even if something went wrong, if we find out that a futex
- * was woken, we don't return error and return this index to
- * userspace
+ * Even if something went wrong, if we find out that any futex
+ * was woken, we don't return error and return the index of the
+ * last futex awaken to userspace
*/
*woken = unqueue_multiple(vs, i);
if (*woken >= 0)
--
2.25.1

2021-12-09 17:18:42

by André Almeida

Subject: Re: [PATCH v4] futex: Clarify comment at futex_wait_multiple_setup()

Às 14:14 de 09/12/21, [email protected] escreveu:
> From: Jangwoong Kim <[email protected]>
>

Almost there, this time you forgot to write something here in the commit
description :)

> Signed-off-by: Jangwoong Kim <[email protected]>
> ---
> kernel/futex/waitwake.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c
> index 4ce0923f1ce3..c7a14ebfe61d 100644
> --- a/kernel/futex/waitwake.c
> +++ b/kernel/futex/waitwake.c
> @@ -454,9 +454,9 @@ static int futex_wait_multiple_setup(struct futex_vector *vs, int count, int *wo
> __set_current_state(TASK_RUNNING);
>
> /*
> - * Even if something went wrong, if we find out that a futex
> - * was woken, we don't return error and return this index to
> - * userspace
> + * Even if something went wrong, if we find out that any futex
> + * was woken, we don't return error and return the index of the
> + * last futex awaken to userspace
> */
> *woken = unqueue_multiple(vs, i);
> if (*woken >= 0)
>