2021-12-10 03:13:56

by Lizhe

Subject: [PATCH] net/netfilter/x_tables.c: Use kvalloc to make your code better

Use kvzalloc () instead of kvmalloc () and memset

Signed-off-by: lizhe <[email protected]>
---
net/netfilter/x_tables.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index 25524e393349..8d6ffed7d526 100644
--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -1189,11 +1189,10 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size)
if (sz < sizeof(*info) || sz >= XT_MAX_TABLE_SIZE)
return NULL;

- info = kvmalloc(sz, GFP_KERNEL_ACCOUNT);
+ info = kvzalloc(sz, GFP_KERNEL_ACCOUNT);
if (!info)
return NULL;

- memset(info, 0, sizeof(*info));
info->size = size;
return info;
}
--
2.25.1

2021-12-10 08:12:33

by Florian Westphal

Subject: Re: [PATCH] net/netfilter/x_tables.c: Use kvalloc to make your code better

lizhe <[email protected]> wrote:
> Use kvzalloc () instead of kvmalloc () and memset
>
> Signed-off-by: lizhe <[email protected]>
> ---
> net/netfilter/x_tables.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
> index 25524e393349..8d6ffed7d526 100644
> --- a/net/netfilter/x_tables.c
> +++ b/net/netfilter/x_tables.c
> @@ -1189,11 +1189,10 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size)
> if (sz < sizeof(*info) || sz >= XT_MAX_TABLE_SIZE)
> return NULL;
>
> - info = kvmalloc(sz, GFP_KERNEL_ACCOUNT);
> + info = kvzalloc(sz, GFP_KERNEL_ACCOUNT);
> if (!info)
> return NULL;
>
> - memset(info, 0, sizeof(*info));

sz != sizeof(*info)