Although this compatible is not used in kernel, as we use the common
MMCI driver, it is used by bootloaders. The U-Boot driver was merged
before the kernel driver and uses this compatible.
To avoid issues when aligning device tree files between kernel and
boot loader, the ST dedicated compatible is added to bindings file.
Signed-off-by: Yann Gautier <[email protected]>
---
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index 47595cb483be..eed54bee7665 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -53,6 +53,12 @@ properties:
items:
- const: arm,pl18x
- const: arm,primecell
+ - description: Entry for STMicroelectronics variant of PL18x.
+ This dedicated compatible is used by bootloaders.
+ items:
+ - const: st,stm32-sdmmc2
+ - const: arm,pl18x
+ - const: arm,primecell
clocks:
description: One or two clocks, the "apb_pclk" and the "MCLK"
--
2.17.1
On Fri, Dec 10, 2021 at 10:19 AM Yann Gautier <[email protected]> wrote:
> Although this compatible is not used in kernel, as we use the common
> MMCI driver, it is used by bootloaders. The U-Boot driver was merged
> before the kernel driver and uses this compatible.
> To avoid issues when aligning device tree files between kernel and
> boot loader, the ST dedicated compatible is added to bindings file.
>
> Signed-off-by: Yann Gautier <[email protected]>
Why not
Acked-by: Linus Walleij <[email protected]>
> + - description: Entry for STMicroelectronics variant of PL18x.
> + This dedicated compatible is used by bootloaders.
> + items:
> + - const: st,stm32-sdmmc2
> + - const: arm,pl18x
> + - const: arm,primecell
You *could* mark it deprecated if it's not supposed to be used.
But no strong opinion.
Yours,
Linus Walleij
On Fri, 10 Dec 2021 10:18:34 +0100, Yann Gautier wrote:
> Although this compatible is not used in kernel, as we use the common
> MMCI driver, it is used by bootloaders. The U-Boot driver was merged
> before the kernel driver and uses this compatible.
> To avoid issues when aligning device tree files between kernel and
> boot loader, the ST dedicated compatible is added to bindings file.
>
> Signed-off-by: Yann Gautier <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
On Fri, 10 Dec 2021 at 10:19, Yann Gautier <[email protected]> wrote:
>
> Although this compatible is not used in kernel, as we use the common
> MMCI driver, it is used by bootloaders. The U-Boot driver was merged
> before the kernel driver and uses this compatible.
> To avoid issues when aligning device tree files between kernel and
> boot loader, the ST dedicated compatible is added to bindings file.
>
> Signed-off-by: Yann Gautier <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index 47595cb483be..eed54bee7665 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -53,6 +53,12 @@ properties:
> items:
> - const: arm,pl18x
> - const: arm,primecell
> + - description: Entry for STMicroelectronics variant of PL18x.
> + This dedicated compatible is used by bootloaders.
> + items:
> + - const: st,stm32-sdmmc2
> + - const: arm,pl18x
> + - const: arm,primecell
>
> clocks:
> description: One or two clocks, the "apb_pclk" and the "MCLK"
> --
> 2.17.1
>