2021-12-10 22:19:24

by Thomas Gleixner

Subject: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property

From: Thomas Gleixner <[email protected]>

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: [email protected]
---
V3: Use pci_dev property - Jason
V2: Invoke the function with the correct number of arguments - Andy
---
arch/powerpc/platforms/cell/axon_msi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -199,7 +199,6 @@ static struct axon_msic *find_msi_transl
static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
{
struct device_node *dn;
- struct msi_desc *entry;
int len;
const u32 *prop;

@@ -209,10 +208,8 @@ static int setup_msi_msg_address(struct
return -ENODEV;
}

- entry = first_pci_msi_entry(dev);
-
for (; dn; dn = of_get_next_parent(dn)) {
- if (entry->pci.msi_attrib.is_64) {
+ if (!dev->no_64bit_msi) {
prop = of_get_property(dn, "msi-address-64", &len);
if (prop)
break;

2021-12-11 15:22:04

by Arnd Bergmann

Subject: Re: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property

On Fri, Dec 10, 2021 at 11:18 PM Thomas Gleixner <[email protected]> wrote:
>
> From: Thomas Gleixner <[email protected]>
>
> instead of fiddling with MSI descriptors.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: [email protected]
> ---

Acked-by: Arnd Bergmann <[email protected]>

2021-12-13 14:01:27

by Jason Gunthorpe

Subject: Re: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property

On Fri, Dec 10, 2021 at 11:18:51PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <[email protected]>
>
> instead of fiddling with MSI descriptors.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: [email protected]
> ---
> V3: Use pci_dev property - Jason
> V2: Invoke the function with the correct number of arguments - Andy
> ---
> arch/powerpc/platforms/cell/axon_msi.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason

2021-12-16 21:43:09

by tip-bot2 for Alexey Makhalov

Subject: [tip: irq/msi] powerpc/cell/axon_msi: Use PCI device property

The following commit has been merged into the irq/msi branch of tip:

Commit-ID: d8a530578b166f3ec55d453b8b4b49599bd39884
Gitweb: https://git.kernel.org/tip/d8a530578b166f3ec55d453b8b4b49599bd39884
Author: Thomas Gleixner <[email protected]>
AuthorDate: Fri, 10 Dec 2021 23:18:51 +01:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Thu, 16 Dec 2021 22:16:38 +01:00

powerpc/cell/axon_msi: Use PCI device property

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
arch/powerpc/platforms/cell/axon_msi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
index 79e2112..ac59aee 100644
--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -199,7 +199,6 @@ out_error:
static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
{
struct device_node *dn;
- struct msi_desc *entry;
int len;
const u32 *prop;

@@ -209,10 +208,8 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
return -ENODEV;
}

- entry = first_pci_msi_entry(dev);
-
for (; dn; dn = of_get_next_parent(dn)) {
- if (entry->pci.msi_attrib.is_64) {
+ if (!dev->no_64bit_msi) {
prop = of_get_property(dn, "msi-address-64", &len);
if (prop)
break;