2021-12-13 19:03:45

by Prabhakar Mahadev Lad

[permalink] [raw]

Subject: [PATCH] leds: ktd2692: Drop calling dev_of_node() in ktd2692_parse_dt

---

output of dev_of_node() is already assigned to "np" variable in
ktd2692_parse_dt(). Use "np" variable to check if OF node is NULL
instead of calling dev_of_node() again.

Signed-off-by: Lad Prabhakar <[email protected]>
---
drivers/leds/flash/leds-ktd2692.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c
index f341da1503a4..ed1f20a58bf6 100644
--- a/drivers/leds/flash/leds-ktd2692.c
+++ b/drivers/leds/flash/leds-ktd2692.c
@@ -274,7 +274,7 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,
struct device_node *child_node;
int ret;

- if (!dev_of_node(dev))
+ if (!np)
return -ENXIO;

led->ctrl_gpio = devm_gpiod_get(dev, "ctrl", GPIOD_ASIS);
--
2.17.1

2021-12-15 20:29:07

by Pavel Machek

[permalink] [raw]

Subject: Re: [PATCH] leds: ktd2692: Drop calling dev_of_node() in ktd2692_parse_dt

---

On Mon 2021-12-13 19:03:31, Lad Prabhakar wrote:
> output of dev_of_node() is already assigned to "np" variable in
> ktd2692_parse_dt(). Use "np" variable to check if OF node is NULL
> instead of calling dev_of_node() again.
>
> Signed-off-by: Lad Prabhakar
<[email protected]>

Thank you, applied.
Pavel

--
http://www.livejournal.com/~pavelmachek

---

Attachments:

(No filename) (381.00 B)
signature.asc (195.00 B)
Download all attachments