2021-12-20 18:42:28

by David Heidelberg

[permalink] [raw]
Subject: [PATCH] dt-bindings: msm: disp: remove bus from dpu bindings

Driver and dts has been already adjusted and bus moved out of dpu, let's
update also dt-bindings.

Fixes warnings as:
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: mdss
@ae00000: clock-names: ['iface', 'core'] is too short
From schema: Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml

Ref: https://lore.kernel.org/all/[email protected]/

Signed-off-by: David Heidelberg <[email protected]>
---
.../devicetree/bindings/display/msm/dpu-sdm845.yaml | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index b4ea7c92fb3d..0dca4b3d66e4 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -31,13 +31,11 @@ properties:
clocks:
items:
- description: Display AHB clock from gcc
- - description: Display AXI clock
- description: Display core clock

clock-names:
items:
- const: iface
- - const: bus
- const: core

interrupts:
@@ -160,9 +158,8 @@ examples:
power-domains = <&dispcc MDSS_GDSC>;

clocks = <&gcc GCC_DISP_AHB_CLK>,
- <&gcc GCC_DISP_AXI_CLK>,
<&dispcc DISP_CC_MDSS_MDP_CLK>;
- clock-names = "iface", "bus", "core";
+ clock-names = "iface", "core";

interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
--
2.34.1



2021-12-20 23:54:10

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: msm: disp: remove bus from dpu bindings

On Mon, 20 Dec 2021 at 21:42, David Heidelberg <[email protected]> wrote:
>
> Driver and dts has been already adjusted and bus moved out of dpu, let's
> update also dt-bindings.
>
> Fixes warnings as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: mdss
> @ae00000: clock-names: ['iface', 'core'] is too short
> From schema: Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
>
> Ref: https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: David Heidelberg <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>

> ---
> .../devicetree/bindings/display/msm/dpu-sdm845.yaml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
> index b4ea7c92fb3d..0dca4b3d66e4 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
> @@ -31,13 +31,11 @@ properties:
> clocks:
> items:
> - description: Display AHB clock from gcc
> - - description: Display AXI clock
> - description: Display core clock
>
> clock-names:
> items:
> - const: iface
> - - const: bus
> - const: core
>
> interrupts:
> @@ -160,9 +158,8 @@ examples:
> power-domains = <&dispcc MDSS_GDSC>;
>
> clocks = <&gcc GCC_DISP_AHB_CLK>,
> - <&gcc GCC_DISP_AXI_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_CLK>;
> - clock-names = "iface", "bus", "core";
> + clock-names = "iface", "core";
>
> interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-controller;
> --
> 2.34.1
>


--
With best wishes
Dmitry

2021-12-22 18:07:47

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: msm: disp: remove bus from dpu bindings

On Mon, 20 Dec 2021 19:42:20 +0100, David Heidelberg wrote:
> Driver and dts has been already adjusted and bus moved out of dpu, let's
> update also dt-bindings.
>
> Fixes warnings as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: mdss
> @ae00000: clock-names: ['iface', 'core'] is too short
> From schema: Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
>
> Ref: https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> .../devicetree/bindings/display/msm/dpu-sdm845.yaml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>

Applied, thanks!