2021-12-21 00:42:51

by Colin Ian King

Subject: [PATCH] video: fbdev: mb862xx: remove redundant assignment to pointer ptr

The pointer ptr is being assigned a value that is never read. The
pointer is being re-assigned later in a loop. The assignment is
redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
index d40b806461ca..61aed7fc0b8d 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
@@ -132,7 +132,7 @@ static void mb86290fb_imageblit8(u32 *cmd, u16 step, u16 dx, u16 dy,
cmd[2] = (height << 16) | width;

i = 0;
- line = ptr = image->data;
+ line = image->data;
bytes = image->width;

while (i < height) {
--
2.32.0

2021-12-21 08:11:41

by Geert Uytterhoeven

Subject: Re: [PATCH] video: fbdev: mb862xx: remove redundant assignment to pointer ptr

On Tue, Dec 21, 2021 at 3:01 AM Colin Ian King <[email protected]> wrote:
> The pointer ptr is being assigned a value that is never read. The
> pointer is being re-assigned later in a loop. The assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds