2021-12-22 16:45:39

by Andy Shevchenko

Subject: [PATCH v1 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Signed-off-by: Andy Shevchenko <[email protected]>
---
include/sound/madera-pdata.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/sound/madera-pdata.h b/include/sound/madera-pdata.h
index e3060f48f108..58398d80c3de 100644
--- a/include/sound/madera-pdata.h
+++ b/include/sound/madera-pdata.h
@@ -9,7 +9,7 @@
#ifndef MADERA_CODEC_PDATA_H
#define MADERA_CODEC_PDATA_H

-#include <linux/kernel.h>
+#include <linux/types.h>

#define MADERA_MAX_INPUT 6
#define MADERA_MAX_MUXED_CHANNELS 4
--
2.34.1

2021-12-29 09:55:09

by Charles Keepax

Subject: Re: [PATCH v1 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions

On Wed, Dec 22, 2021 at 06:45:34PM +0200, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2022-01-24 19:33:07

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions

On Wed, Dec 29, 2021 at 09:53:45AM +0000, Charles Keepax wrote:
> On Wed, Dec 22, 2021 at 06:45:34PM +0200, Andy Shevchenko wrote:
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> >
> > Replace kernel.h inclusion with the list of what is really being used.

> Acked-by: Charles Keepax <[email protected]>

Thanks!

Takashi, should I resend this?

--
With Best Regards,
Andy Shevchenko