2021-12-24 02:34:15

by Jiasheng Jiang

Subject: [PATCH] mfd: intel-lpss: Check for error irq

For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.

Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/mfd/intel-lpss-acpi.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c
index 1f396039d58f..2c073aa294ed 100644
--- a/drivers/mfd/intel-lpss-acpi.c
+++ b/drivers/mfd/intel-lpss-acpi.c
@@ -118,6 +118,7 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev)
{
struct intel_lpss_platform_info *info;
const struct acpi_device_id *id;
+ int ret;

id = acpi_match_device(intel_lpss_acpi_ids, &pdev->dev);
if (!id)
@@ -129,7 +130,12 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev)
return -ENOMEM;

info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- info->irq = platform_get_irq(pdev, 0);
+
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
+ return ret;
+
+ info->irq = ret;

pm_runtime_set_active(&pdev->dev);
pm_runtime_enable(&pdev->dev);
--
2.25.1

2022-02-01 20:43:36

by Lee Jones

Subject: Re: [PATCH] mfd: intel-lpss: Check for error irq

On Fri, 24 Dec 2021, Jiasheng Jiang wrote:

> For the possible failure of the platform_get_irq(), the returned irq
> could be error number and will finally cause the failure of the
> request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
>
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> drivers/mfd/intel-lpss-acpi.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)

This patch no longer seems to apply.

Please rebase it and resubmit with this applied:

For my own reference (apply this as-is to your sign-off block):

Acked-for-MFD-by: Lee Jones <[email protected]>

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog