2021-12-28 21:49:18

by Aleksander Jan Bajkowski

Subject: [PATCH net-next] net: lantiq_etop: add missing comment for wmb()

This patch adds the missing code comment for memory barrier
call and fixes checkpatch warning:

WARNING: memory barrier without comment
+ wmb();

Signed-off-by: Aleksander Jan Bajkowski <[email protected]>
---
drivers/net/ethernet/lantiq_etop.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 072391c494ce..5d90cc147950 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -498,6 +498,7 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
spin_lock_irqsave(&priv->lock, flags);
desc->addr = ((unsigned int) dma_map_single(&priv->pdev->dev, skb->data, len,
DMA_TO_DEVICE)) - byte_offset;
+ /* Make sure the address is written before we give it to HW */
wmb();
desc->ctl = LTQ_DMA_OWN | LTQ_DMA_SOP | LTQ_DMA_EOP |
LTQ_DMA_TX_OFFSET(byte_offset) | (len & LTQ_DMA_SIZE_MASK);
--
2.30.2

2021-12-29 00:20:17

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: lantiq_etop: add missing comment for wmb()

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 28 Dec 2021 22:49:10 +0100 you wrote:
> This patch adds the missing code comment for memory barrier
> call and fixes checkpatch warning:
>
> WARNING: memory barrier without comment
> + wmb();
>
> Signed-off-by: Aleksander Jan Bajkowski <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: lantiq_etop: add missing comment for wmb()
https://git.kernel.org/netdev/net-next/c/723955913e77

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html