2022-01-05 18:07:31

by Prabhakar Mahadev Lad

Subject: [PATCH v2] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure

In case of dma_alloc_coherent() failure return -ENOMEM instead of
returning -EINVAL.

Reported-by: Andy Shevchenko <[email protected]>
Signed-off-by: Lad Prabhakar <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
v1->v2
* Dropped fixes tag as suggested by Florian/Andy
---
drivers/tty/serial/8250/8250_bcm7271.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index cc60a7874e8b..9b878d023dac 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -1075,7 +1075,7 @@ static int brcmuart_probe(struct platform_device *pdev)
priv->rx_size,
&priv->rx_addr, GFP_KERNEL);
if (!priv->rx_bufs) {
- ret = -EINVAL;
+ ret = -ENOMEM;
goto err;
}
priv->tx_size = UART_XMIT_SIZE;
@@ -1083,7 +1083,7 @@ static int brcmuart_probe(struct platform_device *pdev)
priv->tx_size,
&priv->tx_addr, GFP_KERNEL);
if (!priv->tx_buf) {
- ret = -EINVAL;
+ ret = -ENOMEM;
goto err;
}
}
--
2.17.1

2022-01-05 18:11:02

by Florian Fainelli

Subject: Re: [PATCH v2] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure

On 1/5/22 10:07 AM, Lad Prabhakar wrote:
> In case of dma_alloc_coherent() failure return -ENOMEM instead of
> returning -EINVAL.
>
> Reported-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Acked-by: Florian Fainelli <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> ---
> v1->v2
> * Dropped fixes tag as suggested by Florian/Andy

Thanks for the quick turnaround and carrying the tags forward. Cheers
--
Florian