2022-01-07 02:51:18

by Jiabing Wan

Subject: [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy

Fix following coccicheck warning:
./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument
to && or ||

The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/phy/mediatek/phy-mtk-tphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
index 6d307102f4f6..8ee7682b8e93 100644
--- a/drivers/phy/mediatek/phy-mtk-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-tphy.c
@@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy, struct mtk_phy_instance *instanc
/* no efuse, ignore it */
if (!instance->efuse_intr &&
!instance->efuse_rx_imp &&
- !instance->efuse_rx_imp) {
+ !instance->efuse_tx_imp) {
dev_warn(dev, "no u3 intr efuse, but dts enable it\n");
instance->efuse_sw_en = 0;
break;
--
2.34.1

2022-01-07 05:32:03

by Chunfeng Yun

Subject: Re: [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy

On Fri, 2022-01-07 at 10:50 +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument
> to && or ||
>
> The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/phy/mediatek/phy-mtk-tphy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c
> b/drivers/phy/mediatek/phy-mtk-tphy.c
> index 6d307102f4f6..8ee7682b8e93 100644
> --- a/drivers/phy/mediatek/phy-mtk-tphy.c
> +++ b/drivers/phy/mediatek/phy-mtk-tphy.c
> @@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy,
> struct mtk_phy_instance *instanc
> /* no efuse, ignore it */
> if (!instance->efuse_intr &&
> !instance->efuse_rx_imp &&
> - !instance->efuse_rx_imp) {
> + !instance->efuse_tx_imp) {
> dev_warn(dev, "no u3 intr efuse, but dts enable
> it\n");
> instance->efuse_sw_en = 0;
> break;

Acked-by: Chunfeng Yun <[email protected]>

Thanks a lot

2022-01-27 13:23:46

by Vinod Koul

Subject: Re: [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy

On 07-01-22, 10:50, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument
> to && or ||
>
> The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.

Applied, thanks

--
~Vinod