2022-01-10 12:38:40

by Martin Kepplinger

Subject: [PATCH v1 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description

This is supposed to fix "make dt_binding_check":

Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
camera@20: port:endpoint: Unevaluated properties are not allowed
('link-frequencies', 'data-lanes' were unexpected)
From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml

Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---

Link:
https://lore.kernel.org/linux-media/CAL_JsqKzaZC0A4OwnMyAuEWm2pCcHyQxHyrBVtkiPNUeMDd+oA@mail.gmail.com/



Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index 85a8877c2f38..e61255cf3fb9 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -49,7 +49,7 @@ properties:
description: Definition of the regulator used for the VDDD power supply.

port:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base

properties:
endpoint:
--
2.30.2

2022-01-10 12:38:57

by Martin Kepplinger

Subject: [PATCH v1 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description

link-frequencies is required but only mentioned in the example. Add
it to the description.

Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
Signed-off-by: Martin Kepplinger <[email protected]>
---
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index e61255cf3fb9..6b917337ceac 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -68,8 +68,11 @@ properties:
- const: 1
- const: 2

+ link-frequencies: true
+
required:
- data-lanes
+ - link-frequencies

required:
- compatible
--
2.30.2

2022-01-10 13:10:17

by Laurent Pinchart

Subject: Re: [PATCH v1 1/2] dt-binding: media: hynix,hi846: use $defs/port-base port description

Hi Martin,

Thank you for the patch.

On Mon, Jan 10, 2022 at 01:38:03PM +0100, Martin Kepplinger wrote:
> This is supposed to fix "make dt_binding_check":
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
> camera@20: port:endpoint: Unevaluated properties are not allowed
> ('link-frequencies', 'data-lanes' were unexpected)
> From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
>
> Link:
> https://lore.kernel.org/linux-media/CAL_JsqKzaZC0A4OwnMyAuEWm2pCcHyQxHyrBVtkiPNUeMDd+oA@mail.gmail.com/
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 85a8877c2f38..e61255cf3fb9 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -49,7 +49,7 @@ properties:
> description: Definition of the regulator used for the VDDD power supply.
>
> port:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/$defs/port-base

You also need to add

unevaluatedProperties: false

to reject any property that isn't defined in either port-base or in this
schema. Otherwise any extra property in the port node will be accepted.

>
> properties:
> endpoint:

--
Regards,

Laurent Pinchart

2022-01-10 13:10:49

by Laurent Pinchart

Subject: Re: [PATCH v1 2/2] dt-bindings: media: hynix,hi846: add link-frequencies description

Hi Martin,

Thank you for the patch.

On Mon, Jan 10, 2022 at 01:38:04PM +0100, Martin Kepplinger wrote:
> link-frequencies is required but only mentioned in the example. Add
> it to the description.
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Signed-off-by: Martin Kepplinger <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index e61255cf3fb9..6b917337ceac 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -68,8 +68,11 @@ properties:
> - const: 1
> - const: 2
>
> + link-frequencies: true
> +
> required:
> - data-lanes
> + - link-frequencies
>
> required:
> - compatible

--
Regards,

Laurent Pinchart