2022-01-08 09:09:50

by Ming Wang

Subject: [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement.

Even so, there is no syntax error. But, this may be a
clerical error. ';' are more appropriate than ','.

Signed-off-by: Ming Wang <[email protected]>
---
drivers/misc/pci_endpoint_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 2ed7e3a..8f786a2 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -865,7 +865,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
goto err_release_irq;
}
misc_device->parent = &pdev->dev;
- misc_device->fops = &pci_endpoint_test_fops,
+ misc_device->fops = &pci_endpoint_test_fops;

err = misc_register(misc_device);
if (err) {
--
1.8.3.1

2022-01-11 16:23:53

by Bjorn Helgaas

Subject: Re: [PATCH v1] misc: pci_endpoint_test: Use a semicolon as the end of the statement.

On Sat, Jan 08, 2022 at 05:09:37PM +0800, Ming Wang wrote:
> Even so, there is no syntax error. But, this may be a
> clerical error. ';' are more appropriate than ','.
>
> Signed-off-by: Ming Wang <[email protected]>

Applied to pci/misc for v5.17, thanks!

> ---
> drivers/misc/pci_endpoint_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 2ed7e3a..8f786a2 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -865,7 +865,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
> goto err_release_irq;
> }
> misc_device->parent = &pdev->dev;
> - misc_device->fops = &pci_endpoint_test_fops,
> + misc_device->fops = &pci_endpoint_test_fops;
>
> err = misc_register(misc_device);
> if (err) {
> --
> 1.8.3.1
>