2022-01-12 16:10:44

by Jean-Michel Hautbois

[permalink] [raw]
Subject: [PATCH 1/3] media: doc: pixfmt-yuv: Fix V4L2-PIX-FMT-Y10P format

This packed grey-scale image format has a depth of 10 bits per pixel.
Every four consecutive pixels are packed into 5 bytes. Each of the first
4 bytes contain the 8 high order bits of the pixels, and the 5th byte
contains the 2 least significants bits of each pixel, in the same order.

The first two bytes are not corresponding to this description, fix it.

Fixes: af4f45057695 ("media: doc: pixfmt-yuv: Move all luma-only YUV formats to common file")
Signed-off-by: Jean-Michel Hautbois <[email protected]>
---
Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
index 91942c4f0967..8ebd58c3588f 100644
--- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
+++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
@@ -75,8 +75,8 @@ are often referred to as greyscale formats.
- ``V4L2_PIX_FMT_Y10P``
- 'Y10P'

- - Y'\ :sub:`0`\ [7:0]
- - Y'\ :sub:`1`\ [9:8]
+ - Y'\ :sub:`0`\ [9:2]
+ - Y'\ :sub:`1`\ [9:2]
- Y'\ :sub:`2`\ [9:2]
- Y'\ :sub:`3`\ [9:2]
- Y'\ :sub:`3`\ [1:0] Y'\ :sub:`2`\ [1:0] Y'\ :sub:`1`\ [1:0] Y'\ :sub:`0`\ [1:0]
--
2.32.0



2022-01-12 16:16:54

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 1/3] media: doc: pixfmt-yuv: Fix V4L2-PIX-FMT-Y10P format

Hi Jean-Michel,

Thank you for the patch.

On Wed, Jan 12, 2022 at 05:10:12PM +0100, Jean-Michel Hautbois wrote:
> This packed grey-scale image format has a depth of 10 bits per pixel.
> Every four consecutive pixels are packed into 5 bytes. Each of the first
> 4 bytes contain the 8 high order bits of the pixels, and the 5th byte
> contains the 2 least significants bits of each pixel, in the same order.
>
> The first two bytes are not corresponding to this description, fix it.
>
> Fixes: af4f45057695 ("media: doc: pixfmt-yuv: Move all luma-only YUV formats to common file")
> Signed-off-by: Jean-Michel Hautbois <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
> index 91942c4f0967..8ebd58c3588f 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
> @@ -75,8 +75,8 @@ are often referred to as greyscale formats.
> - ``V4L2_PIX_FMT_Y10P``
> - 'Y10P'
>
> - - Y'\ :sub:`0`\ [7:0]
> - - Y'\ :sub:`1`\ [9:8]
> + - Y'\ :sub:`0`\ [9:2]
> + - Y'\ :sub:`1`\ [9:2]
> - Y'\ :sub:`2`\ [9:2]
> - Y'\ :sub:`3`\ [9:2]
> - Y'\ :sub:`3`\ [1:0] Y'\ :sub:`2`\ [1:0] Y'\ :sub:`1`\ [1:0] Y'\ :sub:`0`\ [1:0]

--
Regards,

Laurent Pinchart