2022-01-12 21:17:09

by Gary Bisson

Subject: [PATCH v2 3/3] arm64: dts: meson-g12-common: add uart_ao_b pins muxing

- RX/TX signals can be mapped on 2 different pairs of pins so supporting
both options
- RTS/CTS signals however only have 1 option available

Signed-off-by: Gary Bisson <[email protected]>
---
Changes v1->v2:
- renamed nodes as suggested by Neil

Cc: Rob Herring <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Kevin Hilman <[email protected]>
Cc: Jerome Brunet <[email protected]>
Cc: Martin Blumenstingl <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
.../boot/dts/amlogic/meson-g12-common.dtsi | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index af1357c48bee..62350c408e16 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -1952,6 +1952,33 @@ mux {
};
};

+ uart_ao_b_2_3_pins: uart-ao-b-2-3 {
+ mux {
+ groups = "uart_ao_b_tx_2",
+ "uart_ao_b_rx_3";
+ function = "uart_ao_b";
+ bias-disable;
+ };
+ };
+
+ uart_ao_b_8_9_pins: uart-ao-b-8-9 {
+ mux {
+ groups = "uart_ao_b_tx_8",
+ "uart_ao_b_rx_9";
+ function = "uart_ao_b";
+ bias-disable;
+ };
+ };
+
+ uart_ao_b_cts_rts_pins: uart-ao-b-cts-rts {
+ mux {
+ groups = "uart_ao_b_cts",
+ "uart_ao_b_rts";
+ function = "uart_ao_b";
+ bias-disable;
+ };
+ };
+
pwm_a_e_pins: pwm-a-e {
mux {
groups = "pwm_a_e";
--
2.34.1

2022-01-13 08:59:02

by Neil Armstrong

Subject: Re: [PATCH v2 3/3] arm64: dts: meson-g12-common: add uart_ao_b pins muxing

On 12/01/2022 22:16, Gary Bisson wrote:
> - RX/TX signals can be mapped on 2 different pairs of pins so supporting
> both options
> - RTS/CTS signals however only have 1 option available
>
> Signed-off-by: Gary Bisson <[email protected]>
> ---
> Changes v1->v2:
> - renamed nodes as suggested by Neil
>
> Cc: Rob Herring <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Kevin Hilman <[email protected]>
> Cc: Jerome Brunet <[email protected]>
> Cc: Martin Blumenstingl <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> .../boot/dts/amlogic/meson-g12-common.dtsi | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index af1357c48bee..62350c408e16 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1952,6 +1952,33 @@ mux {
> };
> };
>
> + uart_ao_b_2_3_pins: uart-ao-b-2-3 {
> + mux {
> + groups = "uart_ao_b_tx_2",
> + "uart_ao_b_rx_3";
> + function = "uart_ao_b";
> + bias-disable;
> + };
> + };
> +
> + uart_ao_b_8_9_pins: uart-ao-b-8-9 {
> + mux {
> + groups = "uart_ao_b_tx_8",
> + "uart_ao_b_rx_9";
> + function = "uart_ao_b";
> + bias-disable;
> + };
> + };
> +
> + uart_ao_b_cts_rts_pins: uart-ao-b-cts-rts {
> + mux {
> + groups = "uart_ao_b_cts",
> + "uart_ao_b_rts";
> + function = "uart_ao_b";
> + bias-disable;
> + };
> + };
> +
> pwm_a_e_pins: pwm-a-e {
> mux {
> groups = "pwm_a_e";
>

Reviewed-by: Neil Armstrong <[email protected]>

Thanks !
Neil