2022-01-13 18:09:13

by Greg Kroah-Hartman

Subject: [PATCH] ubifs: use default_groups in kobj_type

There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field. Move the AMD mce sysfs code to use default_groups field which
has been the preferred way since aa30f47cf666 ("kobject: Add support for
default attribute groups to kobj_type") so that we can soon get rid of
the obsolete default_attrs field.

Cc: Richard Weinberger <[email protected]>
Cc: Stefan Schaeckeler <[email protected]>
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
fs/ubifs/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c
index 7acc5a74e5fa..06ad8fa1fcfb 100644
--- a/fs/ubifs/sysfs.c
+++ b/fs/ubifs/sysfs.c
@@ -42,6 +42,7 @@ static struct attribute *ubifs_attrs[] = {
ATTR_LIST(errors_crc),
NULL,
};
+ATTRIBUTE_GROUPS(ubifs);

static ssize_t ubifs_attr_show(struct kobject *kobj,
struct attribute *attr, char *buf)
@@ -74,7 +75,7 @@ static const struct sysfs_ops ubifs_attr_ops = {
};

static struct kobj_type ubifs_sb_ktype = {
- .default_attrs = ubifs_attrs,
+ .default_groups = ubifs_groups,
.sysfs_ops = &ubifs_attr_ops,
.release = ubifs_sb_release,
};
--
2.34.1

2022-01-14 10:08:10

by Michael Walle

Subject: Re: [PATCH] ubifs: use default_groups in kobj_type

Hi,

Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field. Move the AMD mce sysfs code to use default_groups field which

copy & paste mistake?

> has been the preferred way since aa30f47cf666 ("kobject: Add support
> for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.

-michael

2022-01-14 10:19:11

by Greg Kroah-Hartman

Subject: Re: [PATCH] ubifs: use default_groups in kobj_type

On Fri, Jan 14, 2022 at 11:08:03AM +0100, Michael Walle wrote:
> Hi,
>
> Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the AMD mce sysfs code to use default_groups field which
>
> copy & paste mistake?

Ugh, yes, sorry, will go fix this up, thanks...

greg k-h