2022-01-13 21:18:28

by Andrew Geissler

[permalink] [raw]
Subject: [PATCH 1/2] ARM: dts: aspeed: rainier: add reset-cause-pinhole

This GPIO is used on the rainier system to indicate the BMC was reset
due to a physical pinhole reset.

See the following doc for more information:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md

Signed-off-by: Andrew Geissler <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index cfaa606666e2..7ea70c7d698f 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -247,7 +247,8 @@ &gpio0 {
/*C0-C7*/ "","","","","","","","",
/*D0-D7*/ "","","","","","","","",
/*E0-E7*/ "","","","","","","","",
- /*F0-F7*/ "","","battery-voltage-read-enable","","","","factory-reset-toggle","",
+ /*F0-F7*/ "","","battery-voltage-read-enable","reset-cause-pinhole","","",
+ "factory-reset-toggle","",
/*G0-G7*/ "","","","","","","","",
/*H0-H7*/ "","bmc-ingraham0","rear-enc-id0","rear-enc-fault0","","","","",
/*I0-I7*/ "","","","","","","bmc-secure-boot","",
--
2.25.1



2022-01-13 21:18:31

by Andrew Geissler

[permalink] [raw]
Subject: [PATCH 2/2] ARM: dts: aspeed: everest: add reset-cause-pinhole

This GPIO is used on the everest system to indicate the BMC was reset
due to a physical pinhole reset.

It has been verified that the previous name for this pin has not been
utilized by userspace so the name change is ok.

See the following doc for more information:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md

Signed-off-by: Andrew Geissler <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
index f48b33b0c606..6b5d5c56951f 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
@@ -271,7 +271,7 @@ &gpio0 {
/*D0-D7*/ "","","","","","","","",
/*E0-E7*/ "","","","","","","","",
/*F0-F7*/ "PIN_HOLE_RESET_IN_N","","battery-voltage-read-enable",
- "PIN_HOLE_RESET_OUT_N","","",
+ "reset-cause-pinhole","","",
"factory-reset-toggle","",
/*G0-G7*/ "","","","","","","","",
/*H0-H7*/ "led-rtc-battery","led-bmc","led-rear-enc-id0","led-rear-enc-fault0","","","","",
--
2.25.1


2022-01-13 22:35:49

by Joel Stanley

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: aspeed: rainier: add reset-cause-pinhole

Hi Andrew,

On Thu, 13 Jan 2022 at 21:18, Andrew Geissler <[email protected]> wrote:
>
> This GPIO is used on the rainier system to indicate the BMC was reset
> due to a physical pinhole reset.
>
> See the following doc for more information:
> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md
>
> Signed-off-by: Andrew Geissler <[email protected]>

I couldn't apply these cleanly to any tree I had. I think you had a
patch to add battery-voltage-read-enable, but that's not in the tree
yet.

I fixed them up to apply.

Cheers,

Joel

> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index cfaa606666e2..7ea70c7d698f 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -247,7 +247,8 @@ &gpio0 {
> /*C0-C7*/ "","","","","","","","",
> /*D0-D7*/ "","","","","","","","",
> /*E0-E7*/ "","","","","","","","",
> - /*F0-F7*/ "","","battery-voltage-read-enable","","","","factory-reset-toggle","",
> + /*F0-F7*/ "","","battery-voltage-read-enable","reset-cause-pinhole","","",
> + "factory-reset-toggle","",
> /*G0-G7*/ "","","","","","","","",
> /*H0-H7*/ "","bmc-ingraham0","rear-enc-id0","rear-enc-fault0","","","","",
> /*I0-I7*/ "","","","","","","bmc-secure-boot","",
> --
> 2.25.1
>