2022-01-14 13:35:57

by Wen Gu

Subject: [PATCH net] net/smc: Remove unused function declaration

The declaration of smc_wr_tx_dismiss_slots() is unused.
So remove it.

Fixes: 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
Signed-off-by: Wen Gu <[email protected]>
---
net/smc/smc_wr.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/net/smc/smc_wr.h b/net/smc/smc_wr.h
index 47512cc..a54e90a 100644
--- a/net/smc/smc_wr.h
+++ b/net/smc/smc_wr.h
@@ -125,10 +125,6 @@ int smc_wr_tx_v2_send(struct smc_link *link,
int smc_wr_tx_send_wait(struct smc_link *link, struct smc_wr_tx_pend_priv *priv,
unsigned long timeout);
void smc_wr_tx_cq_handler(struct ib_cq *ib_cq, void *cq_context);
-void smc_wr_tx_dismiss_slots(struct smc_link *lnk, u8 wr_rx_hdr_type,
- smc_wr_tx_filter filter,
- smc_wr_tx_dismisser dismisser,
- unsigned long data);
void smc_wr_tx_wait_no_pending_sends(struct smc_link *link);

int smc_wr_rx_register_handler(struct smc_wr_rx_handler *handler);
--
1.8.3.1

2022-01-16 04:51:09

by Dust Li

Subject: Re: [PATCH net] net/smc: Remove unused function declaration

On Fri, Jan 14, 2022 at 09:35:45PM +0800, Wen Gu wrote:
>The declaration of smc_wr_tx_dismiss_slots() is unused.
>So remove it.

Sorry, I missed to remove this

>
>Fixes: 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
>Signed-off-by: Wen Gu <[email protected]>

Reviewed-by: Dust Li <[email protected]>

>---
> net/smc/smc_wr.h | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/net/smc/smc_wr.h b/net/smc/smc_wr.h
>index 47512cc..a54e90a 100644
>--- a/net/smc/smc_wr.h
>+++ b/net/smc/smc_wr.h
>@@ -125,10 +125,6 @@ int smc_wr_tx_v2_send(struct smc_link *link,
> int smc_wr_tx_send_wait(struct smc_link *link, struct smc_wr_tx_pend_priv *priv,
> unsigned long timeout);
> void smc_wr_tx_cq_handler(struct ib_cq *ib_cq, void *cq_context);
>-void smc_wr_tx_dismiss_slots(struct smc_link *lnk, u8 wr_rx_hdr_type,
>- smc_wr_tx_filter filter,
>- smc_wr_tx_dismisser dismisser,
>- unsigned long data);
> void smc_wr_tx_wait_no_pending_sends(struct smc_link *link);
>
> int smc_wr_rx_register_handler(struct smc_wr_rx_handler *handler);
>--
>1.8.3.1

2022-01-16 16:23:50

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net/smc: Remove unused function declaration

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Fri, 14 Jan 2022 21:35:45 +0800 you wrote:
> The declaration of smc_wr_tx_dismiss_slots() is unused.
> So remove it.
>
> Fixes: 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
> Signed-off-by: Wen Gu <[email protected]>
> ---
> net/smc/smc_wr.h | 4 ----
> 1 file changed, 4 deletions(-)

Here is the summary with links:
- [net] net/smc: Remove unused function declaration
https://git.kernel.org/netdev/net/c/9404bc1e58e4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html