Add device tree bindings for the ADMV1014 Upconverter.
Signed-off-by: Antoniu Miclaus <[email protected]>
---
changes in v2:
- move clock description unde `clock-names` section
- expand `p1db-comp-enable` to `p1db-compensation-enable`
- add regulators for all VCC_* supplies, as suggested
.../bindings/iio/frequency/adi,admv1014.yaml | 129 ++++++++++++++++++
1 file changed, 129 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml
diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml
new file mode 100644
index 000000000000..9c43cec72560
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml
@@ -0,0 +1,129 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/frequency/adi,admv1014.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADMV1014 Microwave Downconverter
+
+maintainers:
+ - Antoniu Miclaus <[email protected]>
+
+description: |
+ Wideband, microwave downconverter optimized for point to point microwave
+ radio designs operating in the 24 GHz to 44 GHz frequency range.
+
+ https://www.analog.com/en/products/admv1014.html
+
+properties:
+ compatible:
+ enum:
+ - adi,admv1014
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 1000000
+
+ clocks:
+ minItems: 1
+
+ clock-names:
+ items:
+ - const: lo_in
+ description:
+ Definition of the external clock that serves as input Local Oscillator.
+
+ vcm-supply:
+ description:
+ Common-mode voltage regulator.
+
+ vcc-if-bb-supply:
+ description:
+ BB and IF supply voltage regulator.
+
+ vcc-vga-supply:
+ description:
+ RF Amplifier supply voltage regulator.
+
+ vcc-vva-supply:
+ description:
+ VVA Control Circuit supply voltage regulator.
+
+ vcc-lna-3p3-supply:
+ description:
+ Low Noise Amplifier 3.3V supply voltage regulator.
+
+ vcc-lna-1p5-supply:
+ description:
+ Low Noise Amplifier 1.5V supply voltage regulator.
+
+ vcc-bg-supply:
+ description:
+ Band Gap Circuit supply voltage regulator.
+
+ vcc-quad-supply:
+ description:
+ Quadruple supply voltage regulator.
+
+ vcc-mixer-supply:
+ description:
+ Mixer supply voltage regulator.
+
+ adi,input-mode:
+ description:
+ Select the input mode.
+ iq - in-phase quadrature (I/Q) input
+ if - complex intermediate frequency (IF) input
+ enum: [iq, if]
+
+ adi,detector-enable:
+ description:
+ Digital Rx Detector Enable. The Square Law Detector output is
+ available at output pin VDET.
+ type: boolean
+
+ adi,p1db-compensation-enable:
+ description:
+ Turn on bits to optimize P1dB.
+ type: boolean
+
+ adi,quad-se-mode:
+ description:
+ Switch the LO path from differential to single-ended operation.
+ se-neg - Single-Ended Mode, Negative Side Disabled.
+ se-pos - Single-Ended Mode, Positive Side Disabled.
+ diff - Differential Mode.
+ enum: [se-neg, se-pos, diff]
+
+ '#clock-cells':
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - vcm-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ admv1014@0{
+ compatible = "adi,admv1014";
+ reg = <0>;
+ spi-max-frequency = <1000000>;
+ clocks = <&admv1014_lo>;
+ clock-names = "lo_in";
+ vcm-supply = <&vcm>;
+ adi,quad-se-mode = "diff";
+ adi,detector-enable;
+ adi,p1db-compensation-enable;
+ };
+ };
+...
--
2.34.1
Add documentation for the use of the Digital Attenuator gain.
Signed-off-by: Antoniu Miclaus <[email protected]>
---
.../testing/sysfs-bus-iio-frequency-admv1014 | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
diff --git a/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014 b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
new file mode 100644
index 000000000000..5bcd96d77f45
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
@@ -0,0 +1,23 @@
+What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_coarse
+KernelVersion:
+Contact: [email protected]
+Description:
+ Read/write value for the digital attenuator gain (IF_I) with coarse steps.
+
+What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_coarse
+KernelVersion:
+Contact: [email protected]
+Description:
+ Read/write value for the digital attenuator gain (IF_Q) with coarse steps.
+
+What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_fine
+KernelVersion:
+Contact: [email protected]
+Description:
+ Read/write value for the digital attenuator gain (IF_I) with fine steps.
+
+What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_fine
+KernelVersion:
+Contact: [email protected]
+Description:
+ Read/write value for the digital attenuator gain (IF_Q) with fine steps.
--
2.34.1
On Mon, 10 Jan 2022 17:13:50 +0200
Antoniu Miclaus <[email protected]> wrote:
> Add documentation for the use of the Digital Attenuator gain.
>
> Signed-off-by: Antoniu Miclaus <[email protected]>
Hi Antoniu,
Looks good to me though I'm keen to get other people's opinions as
it is a little unusual. So even if rest of the set is fine I'll
leave this on list for a little longer. (I'm reviewing backwards through
your series as makes more sense to me that way ;)
Thanks,
Jonathan
> ---
> .../testing/sysfs-bus-iio-frequency-admv1014 | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014 b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> new file mode 100644
> index 000000000000..5bcd96d77f45
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> @@ -0,0 +1,23 @@
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_coarse
> +KernelVersion:
> +Contact: [email protected]
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_coarse
> +KernelVersion:
> +Contact: [email protected]
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_fine
> +KernelVersion:
> +Contact: [email protected]
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with fine steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_fine
> +KernelVersion:
> +Contact: [email protected]
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with fine steps.
On Mon, 10 Jan 2022 17:13:49 +0200
Antoniu Miclaus <[email protected]> wrote:
> Add device tree bindings for the ADMV1014 Upconverter.
>
> Signed-off-by: Antoniu Miclaus <[email protected]>
Just one totally trivial comment on this that I could tidy up with applying
if patch 1 is good and others are happy with the series.
Thanks,
Jonathan
> ---
> changes in v2:
> - move clock description unde `clock-names` section
> - expand `p1db-comp-enable` to `p1db-compensation-enable`
> - add regulators for all VCC_* supplies, as suggested
> .../bindings/iio/frequency/adi,admv1014.yaml | 129 ++++++++++++++++++
> 1 file changed, 129 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml
> new file mode 100644
> index 000000000000..9c43cec72560
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml
> @@ -0,0 +1,129 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/frequency/adi,admv1014.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADMV1014 Microwave Downconverter
> +
> +maintainers:
> + - Antoniu Miclaus <[email protected]>
> +
> +description: |
> + Wideband, microwave downconverter optimized for point to point microwave
> + radio designs operating in the 24 GHz to 44 GHz frequency range.
> +
> + https://www.analog.com/en/products/admv1014.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,admv1014
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + clocks:
> + minItems: 1
> +
> + clock-names:
> + items:
> + - const: lo_in
> + description:
> + Definition of the external clock that serves as input Local Oscillator.
Trivial: Not sure "Definition of" adds anything?
External clock that provides the Local Oscilator input.
perhaps?
> +
> + vcm-supply:
> + description:
> + Common-mode voltage regulator.
> +
> + vcc-if-bb-supply:
> + description:
> + BB and IF supply voltage regulator.
> +
> + vcc-vga-supply:
> + description:
> + RF Amplifier supply voltage regulator.
> +
> + vcc-vva-supply:
> + description:
> + VVA Control Circuit supply voltage regulator.
> +
> + vcc-lna-3p3-supply:
> + description:
> + Low Noise Amplifier 3.3V supply voltage regulator.
> +
> + vcc-lna-1p5-supply:
> + description:
> + Low Noise Amplifier 1.5V supply voltage regulator.
> +
> + vcc-bg-supply:
> + description:
> + Band Gap Circuit supply voltage regulator.
> +
> + vcc-quad-supply:
> + description:
> + Quadruple supply voltage regulator.
> +
> + vcc-mixer-supply:
> + description:
> + Mixer supply voltage regulator.
> +
> + adi,input-mode:
> + description:
> + Select the input mode.
> + iq - in-phase quadrature (I/Q) input
> + if - complex intermediate frequency (IF) input
> + enum: [iq, if]
> +
> + adi,detector-enable:
> + description:
> + Digital Rx Detector Enable. The Square Law Detector output is
> + available at output pin VDET.
> + type: boolean
> +
> + adi,p1db-compensation-enable:
> + description:
> + Turn on bits to optimize P1dB.
> + type: boolean
> +
> + adi,quad-se-mode:
> + description:
> + Switch the LO path from differential to single-ended operation.
> + se-neg - Single-Ended Mode, Negative Side Disabled.
> + se-pos - Single-Ended Mode, Positive Side Disabled.
> + diff - Differential Mode.
> + enum: [se-neg, se-pos, diff]
> +
> + '#clock-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - vcm-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + admv1014@0{
> + compatible = "adi,admv1014";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + clocks = <&admv1014_lo>;
> + clock-names = "lo_in";
> + vcm-supply = <&vcm>;
> + adi,quad-se-mode = "diff";
> + adi,detector-enable;
> + adi,p1db-compensation-enable;
> + };
> + };
> +...