2022-01-17 17:01:33

by Kevin Tang

[permalink] [raw]
Subject: [PATCH v2 0/3] sprd drm cover letter

v1:
remove the selected DRM_KMS_CMA_HELPER in kconfig
drm-sprd-fix-potential-NULL-dereference

v2:
fix commit comments long lines issue and drop "On linux-next" comments
Split checking platform_get_resource() return value to a separate patch
Use dev_warn() instead of removing the warning log

Kevin Tang (3):
drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
drm/sprd: fix potential NULL dereference
drm/sprd: check the platform_get_resource() return value

drivers/gpu/drm/sprd/Kconfig | 1 -
drivers/gpu/drm/sprd/sprd_dpu.c | 5 +++++
drivers/gpu/drm/sprd/sprd_drm.c | 2 +-
drivers/gpu/drm/sprd/sprd_dsi.c | 5 +++++
4 files changed, 11 insertions(+), 2 deletions(-)

--
2.29.0


2022-01-17 17:01:33

by Kevin Tang

[permalink] [raw]
Subject: [PATCH v2 1/3] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig

On commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master"),
adds the config DRM_SPRD, which selects DRM_KMS_CMA_HELPER.

However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER
option") just removed the DRM_KMS_CMA_HELPER.
So the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.

Reported-by: Lukas Bulwahn <[email protected]>
Signed-off-by: Kevin Tang <[email protected]>
Reviewed-by: Javier Martinez Canillas <[email protected]>
Acked-by: Thomas Zimmermann <[email protected]>
Reviewed-by: Lukas Bulwahn <[email protected]>

v1 -> v2:
- fix commit comments long lines issue and drop "On linux-next" comments
---
drivers/gpu/drm/sprd/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig
index 3edeaeca0..9a9c7ebfc 100644
--- a/drivers/gpu/drm/sprd/Kconfig
+++ b/drivers/gpu/drm/sprd/Kconfig
@@ -3,7 +3,6 @@ config DRM_SPRD
depends on ARCH_SPRD || COMPILE_TEST
depends on DRM && OF
select DRM_GEM_CMA_HELPER
- select DRM_KMS_CMA_HELPER
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select VIDEOMODE_HELPERS
--
2.29.0