2022-01-21 18:55:20

by Ben Chuang

Subject: [PATCH 1/3] mmc: sdhci-pci-gli: Reduce the SSC value at 205MHz for GL9750 and GL9755

From: Ben Chuang <[email protected]>

The SSC value is 0xFFE7 at 205MHz and may be saturated. Reduce the SSC
value to 0x5A1D at 205MHz to reduce this situation for GL9750 and GL9755.

Signed-off-by: Ben Chuang <[email protected]>
---
drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index 4fd99c1e82ba..9ead32d73447 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -390,7 +390,7 @@ static void gl9750_set_ssc(struct sdhci_host *host, u8 enable, u8 step, u16 ppm)
static void gl9750_set_ssc_pll_205mhz(struct sdhci_host *host)
{
/* set pll to 205MHz and enable ssc */
- gl9750_set_ssc(host, 0x1, 0x1F, 0xFFE7);
+ gl9750_set_ssc(host, 0x1, 0xF, 0x5A1D);
gl9750_set_pll(host, 0x1, 0x246, 0x0);
}

@@ -533,7 +533,7 @@ static void gl9755_set_ssc(struct pci_dev *pdev, u8 enable, u8 step, u16 ppm)
static void gl9755_set_ssc_pll_205mhz(struct pci_dev *pdev)
{
/* set pll to 205MHz and enable ssc */
- gl9755_set_ssc(pdev, 0x1, 0x1F, 0xFFE7);
+ gl9755_set_ssc(pdev, 0x1, 0xF, 0x5A1D);
gl9755_set_pll(pdev, 0x1, 0x246, 0x0);
}

--
2.34.1

2022-01-24 19:23:18

by Ulf Hansson

Subject: Re: [PATCH 1/3] mmc: sdhci-pci-gli: Reduce the SSC value at 205MHz for GL9750 and GL9755

On Wed, 19 Jan 2022 at 08:53, Ben Chuang <[email protected]> wrote:
>
> From: Ben Chuang <[email protected]>
>
> The SSC value is 0xFFE7 at 205MHz and may be saturated. Reduce the SSC
> value to 0x5A1D at 205MHz to reduce this situation for GL9750 and GL9755.
>
> Signed-off-by: Ben Chuang <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 4fd99c1e82ba..9ead32d73447 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -390,7 +390,7 @@ static void gl9750_set_ssc(struct sdhci_host *host, u8 enable, u8 step, u16 ppm)
> static void gl9750_set_ssc_pll_205mhz(struct sdhci_host *host)
> {
> /* set pll to 205MHz and enable ssc */
> - gl9750_set_ssc(host, 0x1, 0x1F, 0xFFE7);
> + gl9750_set_ssc(host, 0x1, 0xF, 0x5A1D);
> gl9750_set_pll(host, 0x1, 0x246, 0x0);
> }
>
> @@ -533,7 +533,7 @@ static void gl9755_set_ssc(struct pci_dev *pdev, u8 enable, u8 step, u16 ppm)
> static void gl9755_set_ssc_pll_205mhz(struct pci_dev *pdev)
> {
> /* set pll to 205MHz and enable ssc */
> - gl9755_set_ssc(pdev, 0x1, 0x1F, 0xFFE7);
> + gl9755_set_ssc(pdev, 0x1, 0xF, 0x5A1D);
> gl9755_set_pll(pdev, 0x1, 0x246, 0x0);
> }
>
> --
> 2.34.1
>